Skip to content

Commit bcb71d4

Browse files
jiangxingitster
authored andcommitted
t1301: do not change $CWD in "shared=all" test case
In test case "shared=all", the working directory is permanently changed to the "sub" directory. This leads to a strange behavior that the temporary repositories created by subsequent test cases are all in this "sub" directory, such as "sub/new", "sub/child.git". If we bypass this test case, all subsequent test cases will have different working directory. Besides, all subsequent test cases assuming they are in the "sub" directory do not run any destructive operations in their parent directory (".."), and will not make damage out side of $TRASH_DIRECTORY. So it is a safe change for us to run the test case "shared=all" in current repository instead of creating and changing to "sub". For the next test case, the path ".git/info" is assumed to be missing, but we no longer run the test case in the "sub" repository which is initialized from an empty template. In order for the test case to run properly, we can set "TEST_CREATE_REPO_NO_TEMPLATE=1" to initialize the default repository without a template. Helped-by: Junio C Hamano <[email protected]> Helped-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Jiang Xin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 5d64229 commit bcb71d4

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

t/t1301-shared-repo.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ test_description='Test shared repository initialization'
88
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
99
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
1010

11+
TEST_CREATE_REPO_NO_TEMPLATE=1
1112
. ./test-lib.sh
1213

1314
# Remove a default ACL from the test dir if possible.
@@ -46,8 +47,6 @@ do
4647
done
4748

4849
test_expect_success 'shared=all' '
49-
mkdir sub &&
50-
cd sub &&
5150
git init --template= --shared=all &&
5251
test 2 = $(git config core.sharedrepository)
5352
'

0 commit comments

Comments
 (0)