Skip to content

Commit bed9b4e

Browse files
phillipwoodgitster
authored andcommitted
rebase --apply: restore some tests
980b482 ("rebase tests: mark tests specific to the am-backend with --am", 2020-02-15) sought to prepare tests testing the "apply" backend in preparation for 2ac0d62 ("rebase: change the default backend from "am" to "merge"", 2020-02-15). However some tests seem to have been missed leading to us testing the "merge" backend twice. This patch fixes some cases that I noticed while adding tests to these files, I have not audited all the other rebase test files. I've reworded a couple of the test descriptions to make it clear which backend they are testing. Signed-off-by: Phillip Wood <[email protected]> Reviewed-by: Elijah Newren <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 118ee5c commit bed9b4e

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

t/t3403-rebase-skip.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ test_expect_success setup '
5252
'
5353

5454
test_expect_success 'rebase with git am -3 (default)' '
55-
test_must_fail git rebase main
55+
test_must_fail git rebase --apply main
5656
'
5757

5858
test_expect_success 'rebase --skip can not be used with other options' '

t/t3418-rebase-continue.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ test_expect_success 'setup' '
2121
git checkout main
2222
'
2323

24-
test_expect_success 'interactive rebase --continue works with touched file' '
24+
test_expect_success 'merge based rebase --continue with works with touched file' '
2525
rm -fr .git/rebase-* &&
2626
git reset --hard &&
2727
git checkout main &&
@@ -31,12 +31,12 @@ test_expect_success 'interactive rebase --continue works with touched file' '
3131
git rebase --continue
3232
'
3333

34-
test_expect_success 'non-interactive rebase --continue works with touched file' '
34+
test_expect_success 'apply based rebase --continue works with touched file' '
3535
rm -fr .git/rebase-* &&
3636
git reset --hard &&
3737
git checkout main &&
3838
39-
test_must_fail git rebase --onto main main topic &&
39+
test_must_fail git rebase --apply --onto main main topic &&
4040
echo "Resolved" >F2 &&
4141
git add F2 &&
4242
test-tool chmtime =-60 F1 &&
@@ -254,7 +254,7 @@ test_rerere_autoupdate () {
254254
'
255255
}
256256

257-
test_rerere_autoupdate
257+
test_rerere_autoupdate --apply
258258
test_rerere_autoupdate -m
259259
GIT_SEQUENCE_EDITOR=: && export GIT_SEQUENCE_EDITOR
260260
test_rerere_autoupdate -i

0 commit comments

Comments
 (0)