Skip to content

Commit c14cc77

Browse files
Thomas Rastgitster
authored andcommitted
coverage: set DEFAULT_TEST_TARGET to avoid using prove
If the user sets DEFAULT_TEST_TARGET=prove in his config.mak, that carries over into the coverage tests. Which is really bad if he also sets GIT_PROVE_OPTS=-j<..> as that completely breaks the coverage runs. Instead of attempting to mess with the GIT_PROVE_OPTS, just force the test target to 'test' so that we run under make, like we intended all along. Signed-off-by: Thomas Rast <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent dcbe7f1 commit c14cc77

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2551,7 +2551,7 @@ coverage-compile:
25512551

25522552
coverage-test: coverage-clean-results coverage-compile
25532553
$(MAKE) CFLAGS="$(COVERAGE_CFLAGS)" LDFLAGS="$(COVERAGE_LDFLAGS)" \
2554-
-j1 test
2554+
DEFAULT_TEST_TARGET=test -j1 test
25552555

25562556
coverage-report:
25572557
$(QUIET_GCOV)for dir in $(object_dirs); do \

0 commit comments

Comments
 (0)