repack: free existing_cruft array after use

peff · gitster · commit c1b754d0597b · 2023-10-09T10:27:34.000-07:00
We allocate an array of packed_git pointers so that we can sort the list
of cruft packs, but we never free the array, causing a small leak. Note
that we don't need to free the packed_git structs themselves; they're
owned by the repository object.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Acked-by: Taylor Blau &lt;me@ttaylorr.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/repack.c b/builtin/repack.c
@@ -955,6 +955,7 @@ static void collapse_small_cruft_packs(FILE *in, size_t max_size,
 			existing->non_kept_packs.items[i].string);
 
 	strbuf_release(&buf);
+	free(existing_cruft);
 }
 
 static int write_cruft_pack(const struct pack_objects_args *args,

Original file line number	Diff line number	Diff line change
`@@ -955,6 +955,7 @@ static void collapse_small_cruft_packs(FILE *in, size_t max_size,`
`955`	`955`	`existing->non_kept_packs.items[i].string);`
`956`	`956`
`957`	`957`	`strbuf_release(&buf);`
	`958`	`+ free(existing_cruft);`
`958`	`959`	`}`
`959`	`960`
`960`	`961`	`static int write_cruft_pack(const struct pack_objects_args *args,`