Skip to content

Commit c365967

Browse files
committed
Merge branch 'jk/clone-unborn-head-in-bare' into maint
"git clone" from a repository whose HEAD is unborn into a bare repository didn't follow the branch name the other side used, which is corrected. * jk/clone-unborn-head-in-bare: clone: handle unborn branch in bare repos
2 parents e61304f + 6b58df5 commit c365967

File tree

2 files changed

+30
-16
lines changed

2 files changed

+30
-16
lines changed

builtin/clone.c

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1340,6 +1340,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
13401340
our_head_points_at = remote_head_points_at;
13411341
}
13421342
else {
1343+
const char *branch;
1344+
char *ref;
1345+
13431346
if (option_branch)
13441347
die(_("Remote branch %s not found in upstream %s"),
13451348
option_branch, remote_name);
@@ -1350,24 +1353,22 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
13501353
remote_head_points_at = NULL;
13511354
remote_head = NULL;
13521355
option_no_checkout = 1;
1353-
if (!option_bare) {
1354-
const char *branch;
1355-
char *ref;
1356-
1357-
if (transport_ls_refs_options.unborn_head_target &&
1358-
skip_prefix(transport_ls_refs_options.unborn_head_target,
1359-
"refs/heads/", &branch)) {
1360-
ref = transport_ls_refs_options.unborn_head_target;
1361-
transport_ls_refs_options.unborn_head_target = NULL;
1362-
create_symref("HEAD", ref, reflog_msg.buf);
1363-
} else {
1364-
branch = git_default_branch_name(0);
1365-
ref = xstrfmt("refs/heads/%s", branch);
1366-
}
13671356

1368-
install_branch_config(0, branch, remote_name, ref);
1369-
free(ref);
1357+
if (transport_ls_refs_options.unborn_head_target &&
1358+
skip_prefix(transport_ls_refs_options.unborn_head_target,
1359+
"refs/heads/", &branch)) {
1360+
ref = transport_ls_refs_options.unborn_head_target;
1361+
transport_ls_refs_options.unborn_head_target = NULL;
1362+
create_symref("HEAD", ref, reflog_msg.buf);
1363+
} else {
1364+
branch = git_default_branch_name(0);
1365+
ref = xstrfmt("refs/heads/%s", branch);
13701366
}
1367+
1368+
if (!option_bare)
1369+
install_branch_config(0, branch, remote_name, ref);
1370+
1371+
free(ref);
13711372
}
13721373

13731374
write_refspec_config(src_ref_prefix, our_head_points_at,

t/t5702-protocol-v2.sh

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,19 @@ test_expect_success '...but not if explicitly forbidden by config' '
237237
! grep "refs/heads/mydefaultbranch" file_empty_child/.git/HEAD
238238
'
239239

240+
test_expect_success 'bare clone propagates empty default branch' '
241+
test_when_finished "rm -rf file_empty_parent file_empty_child.git" &&
242+
243+
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME= \
244+
git -c init.defaultBranch=mydefaultbranch init file_empty_parent &&
245+
246+
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME= \
247+
git -c init.defaultBranch=main -c protocol.version=2 \
248+
clone --bare \
249+
"file://$(pwd)/file_empty_parent" file_empty_child.git &&
250+
grep "refs/heads/mydefaultbranch" file_empty_child.git/HEAD
251+
'
252+
240253
test_expect_success 'fetch with file:// using protocol v2' '
241254
test_when_finished "rm -f log" &&
242255

0 commit comments

Comments
 (0)