Skip to content

Commit c39e9eb

Browse files
committed
Merge branch 'maint'
* maint: gitweb/README: Document $base_url Documentation: git submodule: add missing options to synopsis Better usage string for reflog. hg-to-git: don't import the unused popen2 module send-email: remove debug trace config: Keep inner whitespace verbatim
2 parents f621a84 + f0df129 commit c39e9eb

File tree

7 files changed

+19
-11
lines changed

7 files changed

+19
-11
lines changed

Documentation/git-submodule.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ SYNOPSIS
1414
'git submodule' [--quiet] status [--cached] [--] [<path>...]
1515
'git submodule' [--quiet] init [--] [<path>...]
1616
'git submodule' [--quiet] update [--init] [-N|--no-fetch] [--rebase]
17-
[--reference <repository>] [--] [<path>...]
18-
'git submodule' [--quiet] summary [--summary-limit <n>] [commit] [--] [<path>...]
17+
[--reference <repository>] [--merge] [--] [<path>...]
18+
'git submodule' [--quiet] summary [--cached] [--summary-limit <n>] [commit] [--] [<path>...]
1919
'git submodule' [--quiet] foreach <command>
2020
'git submodule' [--quiet] sync [--] [<path>...]
2121

builtin-reflog.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix)
694694
*/
695695

696696
static const char reflog_usage[] =
697-
"git reflog (expire | ...)";
697+
"git reflog [ show | expire | delete ]";
698698

699699
int cmd_reflog(int argc, const char **argv, const char *prefix)
700700
{

config.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ static char *parse_value(void)
6262
if (comment)
6363
continue;
6464
if (isspace(c) && !quote) {
65-
space = 1;
65+
if (len)
66+
space++;
6667
continue;
6768
}
6869
if (!quote) {
@@ -71,11 +72,8 @@ static char *parse_value(void)
7172
continue;
7273
}
7374
}
74-
if (space) {
75-
if (len)
76-
value[len++] = ' ';
77-
space = 0;
78-
}
75+
for (; space; space--)
76+
value[len++] = ' ';
7977
if (c == '\\') {
8078
c = get_next_char();
8179
switch (c) {

contrib/hg-to-git/hg-to-git.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"""
2121

2222
import os, os.path, sys
23-
import tempfile, popen2, pickle, getopt
23+
import tempfile, pickle, getopt
2424
import re
2525

2626
# Maps hg version -> git version

git-send-email.perl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,6 @@ ($)
450450
try {
451451
$repo->command('rev-parse', '--verify', '--quiet', $f);
452452
if (defined($format_patch)) {
453-
print "foo\n";
454453
return $format_patch;
455454
}
456455
die(<<EOF);

gitweb/README

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,12 @@ not include variables usually directly set during build):
165165
Full URL and absolute URL of gitweb script;
166166
in earlier versions of gitweb you might have need to set those
167167
variables, now there should be no need to do it.
168+
* $base_url
169+
Base URL for relative URLs in pages generated by gitweb,
170+
(e.g. $logo, $favicon, @stylesheets if they are relative URLs),
171+
needed and used only for URLs with nonempty PATH_INFO via
172+
<base href="$base_url>. Usually gitweb sets its value correctly,
173+
and there is no need to set this variable, e.g. to $my_uri or "/".
168174
* $home_link
169175
Target of the home link on top of all pages (the first part of view
170176
"breadcrumbs"). By default set to absolute URI of a page ($my_uri).

t/t1300-repo-config.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -755,6 +755,11 @@ echo >>result
755755

756756
test_expect_success '--null --get-regexp' 'cmp result expect'
757757

758+
test_expect_success 'inner whitespace kept verbatim' '
759+
git config section.val "foo bar" &&
760+
test "z$(git config section.val)" = "zfoo bar"
761+
'
762+
758763
test_expect_success SYMLINKS 'symlinked configuration' '
759764
760765
ln -s notyet myconfig &&

0 commit comments

Comments
 (0)