Skip to content

Commit c82af12

Browse files
devzero2000gitster
authored andcommitted
git-bisect.sh: avoid "test <cond> -a/-o <cond>"
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test <cond> && test <cond>" spawning one extra process by using a single "test <cond> -a <cond>" no longer exists. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6f34b79 commit c82af12

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

git-bisect.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ bisect_replay () {
408408
bisect_reset
409409
while read git bisect command rev
410410
do
411-
test "$git $bisect" = "git bisect" -o "$git" = "git-bisect" || continue
411+
test "$git $bisect" = "git bisect" || test "$git" = "git-bisect" || continue
412412
if test "$git" = "git-bisect"
413413
then
414414
rev="$command"

0 commit comments

Comments
 (0)