notes: fix malformed tree entry

gitster · gitster · commit c88f0cc78e2b · 2010-02-24T21:39:06.000-08:00
The mode bits for entries in a tree object should be an octal number
with minimum number of digits.  Do not pad it with 0 to the left.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/notes.c b/notes.c
@@ -624,8 +624,8 @@ static void write_tree_entry(struct strbuf *buf, unsigned int mode,
 		const char *path, unsigned int path_len, const
 		unsigned char *sha1)
 {
-		strbuf_addf(buf, "%06o %.*s%c", mode, path_len, path, '\0');
-		strbuf_add(buf, sha1, 20);
+	strbuf_addf(buf, "%o %.*s%c", mode, path_len, path, '\0');
+	strbuf_add(buf, sha1, 20);
 }
 
 static void tree_write_stack_init_subtree(struct tree_write_stack *tws,

Original file line number	Diff line number	Diff line change
`@@ -624,8 +624,8 @@ static void write_tree_entry(struct strbuf *buf, unsigned int mode,`
`624`	`624`	`const char *path, unsigned int path_len, const`
`625`	`625`	`unsigned char *sha1)`
`626`	`626`	`{`
`627`		`- strbuf_addf(buf, "%06o %.*s%c", mode, path_len, path, '\0');`
`628`		`- strbuf_add(buf, sha1, 20);`
	`627`	`+ strbuf_addf(buf, "%o %.*s%c", mode, path_len, path, '\0');`
	`628`	`+ strbuf_add(buf, sha1, 20);`
`629`	`629`	`}`
`630`	`630`
`631`	`631`	`static void tree_write_stack_init_subtree(struct tree_write_stack *tws,`