Skip to content

Commit c8ce376

Browse files
sunshinecogitster
authored andcommitted
t6000-t6999: fix broken &&-chains
Signed-off-by: Eric Sunshine <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 51b8547 commit c8ce376

5 files changed

+17
-17
lines changed

t/t6010-merge-base.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ test_expect_success 'using reflog to find the fork point' '
245245
git commit --allow-empty -m "Derived #$count" &&
246246
git rev-parse HEAD >derived$count &&
247247
git checkout -B base $E || exit 1
248-
done
248+
done &&
249249
250250
for count in 1 2 3
251251
do

t/t6029-merge-subtree.sh

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ test_expect_success 'initial merge' '
5555
git checkout -b work &&
5656
git ls-files -s >actual &&
5757
(
58-
echo "100644 $o1 0 git-gui/git-gui.sh"
58+
echo "100644 $o1 0 git-gui/git-gui.sh" &&
5959
echo "100644 $o2 0 git.c"
6060
) >expected &&
6161
test_cmp expected actual
@@ -72,7 +72,7 @@ test_expect_success 'merge update' '
7272
git pull -s subtree gui master2 &&
7373
git ls-files -s >actual &&
7474
(
75-
echo "100644 $o3 0 git-gui/git-gui.sh"
75+
echo "100644 $o3 0 git-gui/git-gui.sh" &&
7676
echo "100644 $o2 0 git.c"
7777
) >expected &&
7878
test_cmp expected actual
@@ -88,8 +88,8 @@ test_expect_success 'initial ambiguous subtree' '
8888
git checkout -b work2 &&
8989
git ls-files -s >actual &&
9090
(
91-
echo "100644 $o1 0 git-gui/git-gui.sh"
92-
echo "100644 $o1 0 git-gui2/git-gui.sh"
91+
echo "100644 $o1 0 git-gui/git-gui.sh" &&
92+
echo "100644 $o1 0 git-gui2/git-gui.sh" &&
9393
echo "100644 $o2 0 git.c"
9494
) >expected &&
9595
test_cmp expected actual
@@ -101,8 +101,8 @@ test_expect_success 'merge using explicit' '
101101
git pull -Xsubtree=git-gui gui master2 &&
102102
git ls-files -s >actual &&
103103
(
104-
echo "100644 $o3 0 git-gui/git-gui.sh"
105-
echo "100644 $o1 0 git-gui2/git-gui.sh"
104+
echo "100644 $o3 0 git-gui/git-gui.sh" &&
105+
echo "100644 $o1 0 git-gui2/git-gui.sh" &&
106106
echo "100644 $o2 0 git.c"
107107
) >expected &&
108108
test_cmp expected actual
@@ -114,8 +114,8 @@ test_expect_success 'merge2 using explicit' '
114114
git pull -Xsubtree=git-gui2 gui master2 &&
115115
git ls-files -s >actual &&
116116
(
117-
echo "100644 $o1 0 git-gui/git-gui.sh"
118-
echo "100644 $o3 0 git-gui2/git-gui.sh"
117+
echo "100644 $o1 0 git-gui/git-gui.sh" &&
118+
echo "100644 $o3 0 git-gui2/git-gui.sh" &&
119119
echo "100644 $o2 0 git.c"
120120
) >expected &&
121121
test_cmp expected actual

t/t6036-recursive-corner-cases.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ test_expect_success 'merge simple rename+criss-cross with no modifications' '
7272
git rev-parse >actual \
7373
:2:three :3:three &&
7474
git hash-object >>actual \
75-
three~HEAD three~R2^0
75+
three~HEAD three~R2^0 &&
7676
test_cmp expect actual
7777
)
7878
'
@@ -148,7 +148,7 @@ test_expect_success 'merge criss-cross + rename merges with basic modification'
148148
git rev-parse >actual \
149149
:2:three :3:three &&
150150
git hash-object >>actual \
151-
three~HEAD three~R2^0
151+
three~HEAD three~R2^0 &&
152152
test_cmp expect actual
153153
)
154154
'
@@ -228,7 +228,7 @@ test_expect_success 'git detects differently handled merges conflict' '
228228
D:new_a E:new_a &&
229229
git rev-parse >actual \
230230
:2:new_a :3:new_a &&
231-
test_cmp expect actual
231+
test_cmp expect actual &&
232232
233233
git cat-file -p B:new_a >ours &&
234234
git cat-file -p C:new_a >theirs &&

t/t6042-merge-rename-corner-cases.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ test_expect_success 'rename/directory conflict + content merge conflict' '
352352
base:file left-conflict:newfile right:file &&
353353
git rev-parse >actual \
354354
:1:newfile :2:newfile :3:newfile &&
355-
test_cmp expect actual
355+
test_cmp expect actual &&
356356
357357
test_path_is_file newfile/realfile &&
358358
test_path_is_file newfile~HEAD
@@ -580,7 +580,7 @@ test_expect_failure 'detect conflict with rename/rename(1to2)/add-source merge'
580580
C:a A:a B:b C:C &&
581581
git rev-parse >actual \
582582
:3:a :1:a :2:b :3:c &&
583-
test_cmp expect actual
583+
test_cmp expect actual &&
584584
585585
test_path_is_file a &&
586586
test_path_is_file b &&
@@ -680,13 +680,13 @@ test_expect_success 'rename/rename/add-dest merge still knows about conflicting
680680
A:a C:b B:b C:c B:c &&
681681
git rev-parse >actual \
682682
:1:a :2:b :3:b :2:c :3:c &&
683-
test_cmp expect actual
683+
test_cmp expect actual &&
684684
685685
git rev-parse >expect \
686686
C:c B:c C:b B:b &&
687687
git hash-object >actual \
688688
c~HEAD c~B\^0 b~HEAD b~B\^0 &&
689-
test_cmp expect actual
689+
test_cmp expect actual &&
690690
691691
test_path_is_missing b &&
692692
test_path_is_missing c

t/t6043-merge-rename-directories.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3583,7 +3583,7 @@ test_expect_success '11d-check: Avoid losing not-uptodate with rename + D/F conf
35833583
grep -q stuff z/c &&
35843584
test_seq 1 10 >expected &&
35853585
echo stuff >>expected &&
3586-
test_cmp expected z/c
3586+
test_cmp expected z/c &&
35873587
35883588
git ls-files -s >out &&
35893589
test_line_count = 4 out &&

0 commit comments

Comments
 (0)