Skip to content

Commit ca44ef3

Browse files
pks-tgitster
authored andcommitted
ci: make Perforce binaries executable for all users
The Perforce binaries are only made executable for the current user. On GitLab CI though we execute tests as a different user than "root", and thus these binaries may not be executable by that test user at all. This has gone unnoticed so far because those binaries are optional -- in case they don't exist we simply skip over tests requiring them. Fix the setup so that we set the executable bits for all users. Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 9cdeb34 commit ca44ef3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ci/install-dependencies.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ ubuntu-*)
4747
mkdir --parents "$CUSTOM_PATH"
4848
wget --quiet --directory-prefix="$CUSTOM_PATH" \
4949
"$P4WHENCE/bin.linux26x86_64/p4d" "$P4WHENCE/bin.linux26x86_64/p4"
50-
chmod u+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4"
50+
chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4"
5151

5252
wget --quiet "$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz"
5353
tar -xzf "git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz" \

0 commit comments

Comments
 (0)