Skip to content

Commit ca7a5dc

Browse files
chazmcgarveygitster
authored andcommitted
gitweb: fix problem causing erroneous project list
The bug is manifest when running gitweb in a persistent process (e.g. FastCGI, PSGI), and it's easy to reproduce. If a gitweb request includes the searchtext parameter (i.e. s), subsequent requests using the project_list action--which is the default action--and without a searchtext parameter will be filtered by the searchtext value of the first request. This is because the value of the $search_regexp global (the value of which is based on the searchtext parameter) is currently being persisted between requests. Instead, clear $search_regexp before dispatching each request. Signed-off-by: Charles McGarvey <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent edca415 commit ca7a5dc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gitweb/gitweb.perl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,7 @@ sub evaluate_and_validate_params {
10861086
our $search_use_regexp = $input_params{'search_use_regexp'};
10871087

10881088
our $searchtext = $input_params{'searchtext'};
1089-
our $search_regexp;
1089+
our $search_regexp = undef;
10901090
if (defined $searchtext) {
10911091
if (length($searchtext) < 2) {
10921092
die_error(403, "At least two characters are required for search parameter");

0 commit comments

Comments
 (0)