Skip to content

Commit cad06d4

Browse files
Paul Gortmakergitster
authored andcommitted
Makefile: hide stderr of curl-config test
You will get $ make distclean 2>&1 | grep curl /bin/sh: curl-config: not found /bin/sh: curl-config: not found /bin/sh: curl-config: not found /bin/sh: curl-config: not found /bin/sh: curl-config: not found $ if you don't have a curl development package installed. The intent is not to alarm the user, but just to test if there is a new enough curl installed. However, if you look at search engine suggested completions, the above "error" messages are confusing people into thinking curl is a hard requirement. Redirect this error output to /dev/null as it is not necessary to be shown to the end users. Signed-off-by: Paul Gortmaker <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent ed9fe75 commit cad06d4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1564,7 +1564,7 @@ else
15641564
REMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)
15651565
PROGRAM_OBJS += http-fetch.o
15661566
PROGRAMS += $(REMOTE_CURL_NAMES)
1567-
curl_check := $(shell (echo 070908; curl-config --vernum) | sort -r | sed -ne 2p)
1567+
curl_check := $(shell (echo 070908; curl-config --vernum) 2>/dev/null | sort -r | sed -ne 2p)
15681568
ifeq "$(curl_check)" "070908"
15691569
ifndef NO_EXPAT
15701570
PROGRAM_OBJS += http-push.o

0 commit comments

Comments
 (0)