Skip to content

Commit cb338c2

Browse files
avargitster
authored andcommitted
cocci: apply the "commit-reach.h" part of "the_repository.pending"
Apply the part of "the_repository.pending.cocci" pertaining to "commit-reach.h". Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d850b7a commit cb338c2

26 files changed

+72
-60
lines changed

bisect.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -846,7 +846,8 @@ static enum bisect_error check_merge_bases(int rev_nr, struct commit **rev, int
846846
enum bisect_error res = BISECT_OK;
847847
struct commit_list *result;
848848

849-
result = get_merge_bases_many(rev[0], rev_nr - 1, rev + 1);
849+
result = repo_get_merge_bases_many(the_repository, rev[0], rev_nr - 1,
850+
rev + 1);
850851

851852
for (; result; result = result->next) {
852853
const struct object_id *mb = &result->item->object.oid;

builtin/branch.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,8 @@ static int branch_merged(int kind, const char *name,
150150
if (!reference_rev)
151151
reference_rev = head_rev;
152152

153-
merged = reference_rev ? in_merge_bases(rev, reference_rev) : 0;
153+
merged = reference_rev ? repo_in_merge_bases(the_repository, rev,
154+
reference_rev) : 0;
154155

155156
/*
156157
* After the safety valve is fully redefined to "check with
@@ -160,7 +161,7 @@ static int branch_merged(int kind, const char *name,
160161
* a gentle reminder is in order.
161162
*/
162163
if ((head_rev != reference_rev) &&
163-
(head_rev ? in_merge_bases(rev, head_rev) : 0) != merged) {
164+
(head_rev ? repo_in_merge_bases(the_repository, rev, head_rev) : 0) != merged) {
164165
if (merged)
165166
warning(_("deleting branch '%s' that has been merged to\n"
166167
" '%s', but not yet merged to HEAD."),

builtin/fast-import.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1625,7 +1625,7 @@ static int update_branch(struct branch *b)
16251625
if (!old_cmit || !new_cmit)
16261626
return error("Branch %s is missing commits.", b->name);
16271627

1628-
if (!in_merge_bases(old_cmit, new_cmit)) {
1628+
if (!repo_in_merge_bases(the_repository, old_cmit, new_cmit)) {
16291629
warning("Not updating %s"
16301630
" (new tip %s does not contain %s)",
16311631
b->name, oid_to_hex(&b->oid),

builtin/fetch.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -965,7 +965,8 @@ static int update_local_ref(struct ref *ref,
965965

966966
if (fetch_show_forced_updates) {
967967
uint64_t t_before = getnanotime();
968-
fast_forward = in_merge_bases(current, updated);
968+
fast_forward = repo_in_merge_bases(the_repository, current,
969+
updated);
969970
forced_updates_ms += (getnanotime() - t_before) / 1000000;
970971
} else {
971972
fast_forward = 1;

builtin/log.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1649,7 +1649,9 @@ static struct commit *get_base_commit(const char *base_commit,
16491649
return NULL;
16501650
}
16511651
commit = lookup_commit_or_die(&oid, "upstream base");
1652-
base_list = get_merge_bases_many(commit, total, list);
1652+
base_list = repo_get_merge_bases_many(the_repository,
1653+
commit, total,
1654+
list);
16531655
/* There should be one and only one merge base. */
16541656
if (!base_list || base_list->next) {
16551657
if (die_on_failure) {
@@ -1683,7 +1685,9 @@ static struct commit *get_base_commit(const char *base_commit,
16831685
while (rev_nr > 1) {
16841686
for (i = 0; i < rev_nr / 2; i++) {
16851687
struct commit_list *merge_base;
1686-
merge_base = get_merge_bases(rev[2 * i], rev[2 * i + 1]);
1688+
merge_base = repo_get_merge_bases(the_repository,
1689+
rev[2 * i],
1690+
rev[2 * i + 1]);
16871691
if (!merge_base || merge_base->next) {
16881692
if (die_on_failure) {
16891693
die(_("failed to find exact merge base"));
@@ -1701,7 +1705,7 @@ static struct commit *get_base_commit(const char *base_commit,
17011705
rev_nr = DIV_ROUND_UP(rev_nr, 2);
17021706
}
17031707

1704-
if (!in_merge_bases(base, rev[0])) {
1708+
if (!repo_in_merge_bases(the_repository, base, rev[0])) {
17051709
if (die_on_failure) {
17061710
die(_("base commit should be the ancestor of revision list"));
17071711
} else {

builtin/merge-base.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ static int show_merge_base(struct commit **rev, int rev_nr, int show_all)
1313
{
1414
struct commit_list *result, *r;
1515

16-
result = get_merge_bases_many_dirty(rev[0], rev_nr - 1, rev + 1);
16+
result = repo_get_merge_bases_many_dirty(the_repository, rev[0],
17+
rev_nr - 1, rev + 1);
1718

1819
if (!result)
1920
return 1;
@@ -105,7 +106,7 @@ static int handle_is_ancestor(int argc, const char **argv)
105106
die("--is-ancestor takes exactly two commits");
106107
one = get_commit_reference(argv[0]);
107108
two = get_commit_reference(argv[1]);
108-
if (in_merge_bases(one, two))
109+
if (repo_in_merge_bases(the_repository, one, two))
109110
return 0;
110111
else
111112
return 1;

builtin/merge-tree.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,8 @@ static int real_merge(struct merge_tree_options *o,
452452
* Get the merge bases, in reverse order; see comment above
453453
* merge_incore_recursive in merge-ort.h
454454
*/
455-
merge_bases = get_merge_bases(parent1, parent2);
455+
merge_bases = repo_get_merge_bases(the_repository, parent1,
456+
parent2);
456457
if (!merge_bases && !o->allow_unrelated_histories)
457458
die(_("refusing to merge unrelated histories"));
458459
merge_bases = reverse_commit_list(merge_bases);

builtin/merge.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1531,7 +1531,8 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
15311531
if (!remoteheads)
15321532
; /* already up-to-date */
15331533
else if (!remoteheads->next)
1534-
common = get_merge_bases(head_commit, remoteheads->item);
1534+
common = repo_get_merge_bases(the_repository, head_commit,
1535+
remoteheads->item);
15351536
else {
15361537
struct commit_list *list = remoteheads;
15371538
commit_list_insert(head_commit, &list);
@@ -1649,7 +1650,9 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
16491650
* merge_bases again, otherwise "git merge HEAD^
16501651
* HEAD^^" would be missed.
16511652
*/
1652-
common_one = get_merge_bases(head_commit, j->item);
1653+
common_one = repo_get_merge_bases(the_repository,
1654+
head_commit,
1655+
j->item);
16531656
if (!oideq(&common_one->item->object.oid, &j->item->object.oid)) {
16541657
up_to_date = 0;
16551658
break;

builtin/rebase.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -882,7 +882,7 @@ static int can_fast_forward(struct commit *onto, struct commit *upstream,
882882
if (!upstream)
883883
goto done;
884884

885-
merge_bases = get_merge_bases(upstream, head);
885+
merge_bases = repo_get_merge_bases(the_repository, upstream, head);
886886
if (!merge_bases || merge_bases->next)
887887
goto done;
888888

@@ -901,7 +901,8 @@ static void fill_branch_base(struct rebase_options *options,
901901
{
902902
struct commit_list *merge_bases = NULL;
903903

904-
merge_bases = get_merge_bases(options->onto, options->orig_head);
904+
merge_bases = repo_get_merge_bases(the_repository, options->onto,
905+
options->orig_head);
905906
if (!merge_bases || merge_bases->next)
906907
oidcpy(branch_base, null_oid());
907908
else

builtin/receive-pack.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1548,7 +1548,7 @@ static const char *update(struct command *cmd, struct shallow_info *si)
15481548
}
15491549
old_commit = (struct commit *)old_object;
15501550
new_commit = (struct commit *)new_object;
1551-
if (!in_merge_bases(old_commit, new_commit)) {
1551+
if (!repo_in_merge_bases(the_repository, old_commit, new_commit)) {
15521552
rp_error("denying non-fast-forward %s"
15531553
" (you should pull first)", name);
15541554
ret = "non-fast-forward";

0 commit comments

Comments
 (0)