Skip to content

Commit cc999a3

Browse files
hartworkgitster
authored andcommitted
gitweb: Fix unintended "--no-merges" for regular Atom feed
The print_feed_meta() subroutine generates links for feeds with and without merges, in RSS and Atom formats. However because %href_params was not properly reset, it generated links with "--no-merges" for all except the very first link. Before: <link rel="alternate" title="[..] - Atom feed" href="/?p=.git;a=atom;opt=--no-merges" type="application/atom+xml" /> <link rel="alternate" title="[..] - Atom feed (no merges)" href="/?p=.git;a=atom;opt=--no-merges" type="application/atom+xml" /> After: <link rel="alternate" title="[..] - Atom feed" href="/?p=.git;a=atom" type="application/atom+xml" /> <link rel="alternate" title="[..] - Atom feed (no merges)" href="/?p=.git;a=atom;opt=--no-merges" type="application/atom+xml" /> Signed-off-by: Sebastian Pipping <[email protected]> Signed-off-by: Jakub Narebski <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 7945c7f commit cc999a3

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

gitweb/gitweb.perl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3886,6 +3886,7 @@ sub print_feed_meta {
38863886
'-type' => "application/$type+xml"
38873887
);
38883888

3889+
$href_params{'extra_options'} = undef;
38893890
$href_params{'action'} = $type;
38903891
$link_attr{'-href'} = href(%href_params);
38913892
print "<link ".

0 commit comments

Comments
 (0)