Skip to content

Commit cce074a

Browse files
chriscoolgitster
authored andcommitted
bisect: fix another instance of eval'ed string
When there is nothing to be skipped, the output from rev-list --bisect-vars was eval'ed without first being strung together with &&; this is probably not a problem as it is much less likely to be a bad input than the list handcrafted by the filter_skip function, but it still is a good discipline. Signed-off-by: Christian Couder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 1b249ff commit cce074a

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

git-bisect.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,13 @@ filter_skipped() {
263263
_skip="$2"
264264

265265
if [ -z "$_skip" ]; then
266-
eval_rev_list "$_eval"
266+
eval_rev_list "$_eval" | {
267+
while read line
268+
do
269+
echo "$line &&"
270+
done
271+
echo ':'
272+
}
267273
return
268274
fi
269275

0 commit comments

Comments
 (0)