Skip to content

Commit cce076e

Browse files
nforrogitster
authored andcommitted
difftool/mergetool: make the form of yes/no questions consistent
Every yes/no question in difftool/mergetool scripts has slightly different form, and none of them is consistent with the form git itself uses. Make the form of all the questions consistent with the form used by git. Reviewed-by: John Keeping <[email protected]> Signed-off-by: Nikola Forró <[email protected]> Acked-by: David Aguilar <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e465796 commit cce076e

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

git-difftool--helper.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ launch_merge_tool () {
4444
"$GIT_DIFF_PATH_TOTAL" "$MERGED"
4545
if use_ext_cmd
4646
then
47-
printf "Launch '%s' [Y/n]: " \
47+
printf "Launch '%s' [Y/n]? " \
4848
"$GIT_DIFFTOOL_EXTCMD"
4949
else
50-
printf "Launch '%s' [Y/n]: " "$merge_tool"
50+
printf "Launch '%s' [Y/n]? " "$merge_tool"
5151
fi
5252
read ans || return
5353
if test "$ans" = n

git-mergetool--lib.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ check_unchanged () {
100100
while true
101101
do
102102
echo "$MERGED seems unchanged."
103-
printf "Was the merge successful? [y/n] "
103+
printf "Was the merge successful [y/n]? "
104104
read answer || return 1
105105
case "$answer" in
106106
y*|Y*) return 0 ;;

git-mergetool.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ done
396396
prompt_after_failed_merge () {
397397
while true
398398
do
399-
printf "Continue merging other unresolved paths (y/n) ? "
399+
printf "Continue merging other unresolved paths [y/n]? "
400400
read ans || return 1
401401
case "$ans" in
402402
[yY]*)

t/t7800-difftool.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ difftool_test_setup ()
2020
prompt_given ()
2121
{
2222
prompt="$1"
23-
test "$prompt" = "Launch 'test-tool' [Y/n]: branch"
23+
test "$prompt" = "Launch 'test-tool' [Y/n]? branch"
2424
}
2525

2626
# Create a file on master and change it on branch

0 commit comments

Comments
 (0)