Skip to content

Commit cdb73ca

Browse files
hanwengitster
authored andcommitted
t: use update-ref and show-ref to reading/writing refs
Reading and writing .git/refs/* assumes that refs are stored in the 'files' ref backend. Signed-off-by: Han-Wen Nienhuys <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d1eb22d commit cdb73ca

File tree

5 files changed

+21
-21
lines changed

5 files changed

+21
-21
lines changed

t/t0002-gitfile.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ test_expect_success 'check commit-tree' '
6262
'
6363

6464
test_expect_success 'check rev-list' '
65-
echo $SHA >"$REAL/HEAD" &&
65+
git update-ref "HEAD" "$SHA" &&
6666
test "$SHA" = "$(git rev-list HEAD)"
6767
'
6868

t/t1400-update-ref.sh

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,15 @@ test_expect_success setup '
3737

3838
test_expect_success "create $m" '
3939
git update-ref $m $A &&
40-
test $A = $(cat .git/$m)
40+
test $A = $(git show-ref -s --verify $m)
4141
'
4242
test_expect_success "create $m with oldvalue verification" '
4343
git update-ref $m $B $A &&
44-
test $B = $(cat .git/$m)
44+
test $B = $(git show-ref -s --verify $m)
4545
'
4646
test_expect_success "fail to delete $m with stale ref" '
4747
test_must_fail git update-ref -d $m $A &&
48-
test $B = "$(cat .git/$m)"
48+
test $B = "$(git show-ref -s --verify $m)"
4949
'
5050
test_expect_success "delete $m" '
5151
test_when_finished "rm -f .git/$m" &&
@@ -56,7 +56,7 @@ test_expect_success "delete $m" '
5656
test_expect_success "delete $m without oldvalue verification" '
5757
test_when_finished "rm -f .git/$m" &&
5858
git update-ref $m $A &&
59-
test $A = $(cat .git/$m) &&
59+
test $A = $(git show-ref -s --verify $m) &&
6060
git update-ref -d $m &&
6161
test_path_is_missing .git/$m
6262
'
@@ -69,15 +69,15 @@ test_expect_success "fail to create $n" '
6969

7070
test_expect_success "create $m (by HEAD)" '
7171
git update-ref HEAD $A &&
72-
test $A = $(cat .git/$m)
72+
test $A = $(git show-ref -s --verify $m)
7373
'
7474
test_expect_success "create $m (by HEAD) with oldvalue verification" '
7575
git update-ref HEAD $B $A &&
76-
test $B = $(cat .git/$m)
76+
test $B = $(git show-ref -s --verify $m)
7777
'
7878
test_expect_success "fail to delete $m (by HEAD) with stale ref" '
7979
test_must_fail git update-ref -d HEAD $A &&
80-
test $B = $(cat .git/$m)
80+
test $B = $(git show-ref -s --verify $m)
8181
'
8282
test_expect_success "delete $m (by HEAD)" '
8383
test_when_finished "rm -f .git/$m" &&
@@ -178,14 +178,14 @@ test_expect_success '--no-create-reflog overrides core.logAllRefUpdates=always'
178178

179179
test_expect_success "create $m (by HEAD)" '
180180
git update-ref HEAD $A &&
181-
test $A = $(cat .git/$m)
181+
test $A = $(git show-ref -s --verify $m)
182182
'
183183
test_expect_success 'pack refs' '
184184
git pack-refs --all
185185
'
186186
test_expect_success "move $m (by HEAD)" '
187187
git update-ref HEAD $B $A &&
188-
test $B = $(cat .git/$m)
188+
test $B = $(git show-ref -s --verify $m)
189189
'
190190
test_expect_success "delete $m (by HEAD) should remove both packed and loose $m" '
191191
test_when_finished "rm -f .git/$m" &&
@@ -255,27 +255,27 @@ test_expect_success '(not) change HEAD with wrong SHA1' '
255255
'
256256
test_expect_success "(not) changed .git/$m" '
257257
test_when_finished "rm -f .git/$m" &&
258-
! test $B = $(cat .git/$m)
258+
! test $B = $(git show-ref -s --verify $m)
259259
'
260260

261261
rm -f .git/logs/refs/heads/master
262262
test_expect_success "create $m (logged by touch)" '
263263
test_config core.logAllRefUpdates false &&
264264
GIT_COMMITTER_DATE="2005-05-26 23:30" \
265265
git update-ref --create-reflog HEAD $A -m "Initial Creation" &&
266-
test $A = $(cat .git/$m)
266+
test $A = $(git show-ref -s --verify $m)
267267
'
268268
test_expect_success "update $m (logged by touch)" '
269269
test_config core.logAllRefUpdates false &&
270270
GIT_COMMITTER_DATE="2005-05-26 23:31" \
271271
git update-ref HEAD $B $A -m "Switch" &&
272-
test $B = $(cat .git/$m)
272+
test $B = $(git show-ref -s --verify $m)
273273
'
274274
test_expect_success "set $m (logged by touch)" '
275275
test_config core.logAllRefUpdates false &&
276276
GIT_COMMITTER_DATE="2005-05-26 23:41" \
277277
git update-ref HEAD $A &&
278-
test $A = $(cat .git/$m)
278+
test $A = $(git show-ref -s --verify $m)
279279
'
280280

281281
test_expect_success 'empty directory removal' '
@@ -319,19 +319,19 @@ test_expect_success "create $m (logged by config)" '
319319
test_config core.logAllRefUpdates true &&
320320
GIT_COMMITTER_DATE="2005-05-26 23:32" \
321321
git update-ref HEAD $A -m "Initial Creation" &&
322-
test $A = $(cat .git/$m)
322+
test $A = $(git show-ref -s --verify $m)
323323
'
324324
test_expect_success "update $m (logged by config)" '
325325
test_config core.logAllRefUpdates true &&
326326
GIT_COMMITTER_DATE="2005-05-26 23:33" \
327327
git update-ref HEAD'" $B $A "'-m "Switch" &&
328-
test $B = $(cat .git/$m)
328+
test $B = $(git show-ref -s --verify $m)
329329
'
330330
test_expect_success "set $m (logged by config)" '
331331
test_config core.logAllRefUpdates true &&
332332
GIT_COMMITTER_DATE="2005-05-26 23:43" \
333333
git update-ref HEAD $A &&
334-
test $A = $(cat .git/$m)
334+
test $A = $(git show-ref -s --verify $m)
335335
'
336336

337337
cat >expect <<EOF

t/t1506-rev-parse-diagnosis.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ test_expect_success 'arg before dashdash must be a revision (ambiguous)' '
207207
{
208208
# we do not want to use rev-parse here, because
209209
# we are testing it
210-
cat .git/refs/heads/foobar &&
210+
git show-ref -s refs/heads/foobar &&
211211
printf "%s\n" --
212212
} >expect &&
213213
git rev-parse foobar -- >actual &&

t/t6050-replace.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ test_expect_success 'tag replaced commit' '
135135
test_expect_success '"git fsck" works' '
136136
git fsck master >fsck_master.out &&
137137
test_i18ngrep "dangling commit $R" fsck_master.out &&
138-
test_i18ngrep "dangling tag $(cat .git/refs/tags/mytag)" fsck_master.out &&
138+
test_i18ngrep "dangling tag $(git show-ref -s refs/tags/mytag)" fsck_master.out &&
139139
test -z "$(git fsck)"
140140
'
141141

t/t9020-remote-svn.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ test_expect_success REMOTE_SVN 'simple fetch' '
4848
'
4949

5050
test_debug '
51-
cat .git/refs/svn/svnsim/master
52-
cat .git/refs/remotes/svnsim/master
51+
git show-ref -s refs/svn/svnsim/master
52+
git show-ref -s refs/remotes/svnsim/master
5353
'
5454

5555
test_expect_success REMOTE_SVN 'repeated fetch, nothing shall change' '

0 commit comments

Comments
 (0)