Skip to content

Commit ce5dadb

Browse files
devzero2000gitster
authored andcommitted
t/lib-httpd.sh: avoid "test <cond> -a/-o <cond>"
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test <cond> && test <cond>" spawning one extra process by using a single "test <cond> -a <cond>" no longer exists. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e425f6a commit ce5dadb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/lib-httpd.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ prepare_httpd() {
132132
HTTPD_URL_USER=$HTTPD_PROTO://user%40host@$HTTPD_DEST
133133
HTTPD_URL_USER_PASS=$HTTPD_PROTO://user%40host:pass%40host@$HTTPD_DEST
134134

135-
if test -n "$LIB_HTTPD_DAV" -o -n "$LIB_HTTPD_SVN"
135+
if test -n "$LIB_HTTPD_DAV" || test -n "$LIB_HTTPD_SVN"
136136
then
137137
HTTPD_PARA="$HTTPD_PARA -DDAV"
138138

0 commit comments

Comments
 (0)