Skip to content

Commit d24fbca

Browse files
avargitster
authored andcommitted
Remove Git's support for smoke testing
I'm no longer running the Git smoke testing service at smoke.git.nix.is due to Smolder being a fragile piece of software not having time to follow through on making it easy for third parties to run and submit their own smoke tests. So remove the support in Git for sending smoke tests to smoke.git.nix.is, it's still easy to modify the test suite to submit smokes somewhere else. This reverts the following commits: Revert "t/README: Add SMOKE_{COMMENT,TAGS}= to smoke_report target" -- e38efac Revert "t/README: Document the Smoke testing" -- d15e9eb Revert "t/Makefile: Create test-results dir for smoke target" -- 617344d Revert "tests: Infrastructure for Git smoke testing" -- b6b84d1 Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6d62c98 commit d24fbca

File tree

3 files changed

+1
-133
lines changed

3 files changed

+1
-133
lines changed

t/Makefile

Lines changed: 1 addition & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -73,42 +73,4 @@ gitweb-test:
7373
valgrind:
7474
$(MAKE) GIT_TEST_OPTS="$(GIT_TEST_OPTS) --valgrind"
7575

76-
# Smoke testing targets
77-
-include ../GIT-VERSION-FILE
78-
uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo unknown')
79-
uname_M := $(shell sh -c 'uname -m 2>/dev/null || echo unknown')
80-
81-
test-results:
82-
mkdir -p test-results
83-
84-
test-results/git-smoke.tar.gz: test-results
85-
$(PERL_PATH) ./harness \
86-
--archive="test-results/git-smoke.tar.gz" \
87-
$(T)
88-
89-
smoke: test-results/git-smoke.tar.gz
90-
91-
SMOKE_UPLOAD_FLAGS =
92-
ifdef SMOKE_USERNAME
93-
SMOKE_UPLOAD_FLAGS += -F username="$(SMOKE_USERNAME)" -F password="$(SMOKE_PASSWORD)"
94-
endif
95-
ifdef SMOKE_COMMENT
96-
SMOKE_UPLOAD_FLAGS += -F comments="$(SMOKE_COMMENT)"
97-
endif
98-
ifdef SMOKE_TAGS
99-
SMOKE_UPLOAD_FLAGS += -F tags="$(SMOKE_TAGS)"
100-
endif
101-
102-
smoke_report: smoke
103-
curl \
104-
-H "Expect: " \
105-
-F project=Git \
106-
-F architecture="$(uname_M)" \
107-
-F platform="$(uname_S)" \
108-
-F revision="$(GIT_VERSION)" \
109-
-F report_file=@test-results/git-smoke.tar.gz \
110-
$(SMOKE_UPLOAD_FLAGS) \
111-
http://smoke.git.nix.is/app/projects/process_add_report/1 \
112-
| grep -v ^Redirecting
113-
114-
.PHONY: pre-clean $(T) aggregate-results clean valgrind smoke smoke_report
76+
.PHONY: pre-clean $(T) aggregate-results clean valgrind

t/README

Lines changed: 0 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -658,76 +658,3 @@ Then, at the top-level:
658658
That'll generate a detailed cover report in the "cover_db_html"
659659
directory, which you can then copy to a webserver, or inspect locally
660660
in a browser.
661-
662-
Smoke testing
663-
-------------
664-
665-
The Git test suite has support for smoke testing. Smoke testing is
666-
when you submit the results of a test run to a central server for
667-
analysis and aggregation.
668-
669-
Running a smoke tester is an easy and valuable way of contributing to
670-
Git development, particularly if you have access to an uncommon OS on
671-
obscure hardware.
672-
673-
After building Git you can generate a smoke report like this in the
674-
"t" directory:
675-
676-
make clean smoke
677-
678-
You can also pass arguments via the environment. This should make it
679-
faster:
680-
681-
GIT_TEST_OPTS='--root=/dev/shm' TEST_JOBS=10 make clean smoke
682-
683-
The "smoke" target will run the Git test suite with Perl's
684-
"TAP::Harness" module, and package up the results in a .tar.gz archive
685-
with "TAP::Harness::Archive". The former is included with Perl v5.10.1
686-
or later, but you'll need to install the latter from the CPAN. See the
687-
"Test coverage" section above for how you might do that.
688-
689-
Once the "smoke" target finishes you'll see a message like this:
690-
691-
TAP Archive created at <path to git>/t/test-results/git-smoke.tar.gz
692-
693-
To upload the smoke report you need to have curl(1) installed, then
694-
do:
695-
696-
make smoke_report
697-
698-
To upload the report anonymously. Hopefully that'll return something
699-
like "Reported #7 added.".
700-
701-
If you're going to be uploading reports frequently please request a
702-
user account by E-Mailing [email protected]. Once you have a username
703-
and password you'll be able to do:
704-
705-
SMOKE_USERNAME=<username> SMOKE_PASSWORD=<password> make smoke_report
706-
707-
You can also add an additional comment to attach to the report, and/or
708-
a comma separated list of tags:
709-
710-
SMOKE_USERNAME=<username> SMOKE_PASSWORD=<password> \
711-
SMOKE_COMMENT=<comment> SMOKE_TAGS=<tags> \
712-
make smoke_report
713-
714-
Once the report is uploaded it'll be made available at
715-
http://smoke.git.nix.is, here's an overview of Recent Smoke Reports
716-
for Git:
717-
718-
http://smoke.git.nix.is/app/projects/smoke_reports/1
719-
720-
The reports will also be mirrored to GitHub every few hours:
721-
722-
http://github.com/gitsmoke/smoke-reports
723-
724-
The Smolder SQLite database is also mirrored and made available for
725-
download:
726-
727-
http://github.com/gitsmoke/smoke-database
728-
729-
Note that the database includes hashed (with crypt()) user passwords
730-
and E-Mail addresses. Don't use a valuable password for the smoke
731-
service if you have an account, or an E-Mail address you don't want to
732-
be publicly known. The user accounts are just meant to be convenient
733-
labels, they're not meant to be secure.

t/harness

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)