p4merge: fix printf usage

davvid · gitster · commit d272c8497c2a · 2013-02-10T11:40:52.000-08:00
Do not use a random string as if it is a format string for printf
when showing it literally; instead feed it to '%s' format.

Reported-by: Asheesh Laroia &lt;asheesh@asheesh.org&gt;
Signed-off-by: David Aguilar &lt;davvid@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/mergetools/p4merge b/mergetools/p4merge
@@ -30,5 +30,5 @@ create_empty_file () {
 	empty_file="${TMPDIR:-/tmp}/git-difftool-p4merge-empty-file.$$"
 	>"$empty_file"
 
-	printf "$empty_file"
+	printf "%s" "$empty_file"
 }

Original file line number	Diff line number	Diff line change
`@@ -30,5 +30,5 @@ create_empty_file () {`
`30`	`30`	`empty_file="${TMPDIR:-/tmp}/git-difftool-p4merge-empty-file.$$"`
`31`	`31`	`>"$empty_file"`
`32`	`32`
`33`		`- printf "$empty_file"`
	`33`	`+ printf "%s" "$empty_file"`
`34`	`34`	`}`