submodule tests: test for a "foreach" blind-spot

avar · ttaylorr · commit d50d8485ef03 · 2022-11-08T14:55:30.000-05:00
We tested for "--" followed by command names, but not for "--"
followed by an argument that looks like an option, let's do that.

Signed-off-by: Ævar Arnfjörð Bjarmason &lt;avarab@gmail.com&gt;
Signed-off-by: Taylor Blau &lt;me@ttaylorr.com&gt;
diff --git a/t/t7407-submodule-foreach.sh b/t/t7407-submodule-foreach.sh
@@ -154,6 +154,11 @@ test_expect_success 'use "submodule foreach" to checkout 2nd level submodule' '
 	)
 '
 
+test_expect_success 'usage: foreach -- --not-an-option' '
+	test_expect_code 1 git submodule foreach -- --not-an-option &&
+	test_expect_code 1 git -C clone2 submodule foreach -- --not-an-option
+'
+
 test_expect_success 'use "foreach --recursive" to checkout all submodules' '
 	(
 		cd clone2 &&

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,11 @@ test_expect_success 'use "submodule foreach" to checkout 2nd level submodule' '`
`154`	`154`	`)`
`155`	`155`	`'`
`156`	`156`
	`157`	`+test_expect_success 'usage: foreach -- --not-an-option' '`
	`158`	`+ test_expect_code 1 git submodule foreach -- --not-an-option &&`
	`159`	`+ test_expect_code 1 git -C clone2 submodule foreach -- --not-an-option`
	`160`	`+'`
	`161`	`+`
`157`	`162`	`test_expect_success 'use "foreach --recursive" to checkout all submodules' '`
`158`	`163`	`(`
`159`	`164`	`cd clone2 &&`