Skip to content

Commit d702d5c

Browse files
committed
Merge branch 'js/test-with-ws-in-path'
Test fixes. * js/test-with-ws-in-path: t0302 & t3900: add forgotten quotes Allow the test suite to pass in a directory whose name contains spaces
2 parents e693224 + 89a70b8 commit d702d5c

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

t/t0302-credential-store.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ helper_test store
3737
unset XDG_CONFIG_HOME
3838

3939
test_expect_success 'if custom xdg file exists, home and xdg files not created' '
40-
test_when_finished "rm -f $HOME/xdg/git/credentials" &&
40+
test_when_finished "rm -f \"$HOME/xdg/git/credentials\"" &&
4141
test -s "$HOME/xdg/git/credentials" &&
4242
test_path_is_missing "$HOME/.git-credentials" &&
4343
test_path_is_missing "$HOME/.config/git/credentials"

t/t3900-i18n-commit.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ test_expect_success 'UTF-16 refused because of NULs' '
4040
'
4141

4242
test_expect_success 'UTF-8 invalid characters refused' '
43-
test_when_finished "rm -f $HOME/stderr $HOME/invalid" &&
43+
test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
4444
echo "UTF-8 characters" >F &&
4545
printf "Commit message\n\nInvalid surrogate:\355\240\200\n" \
4646
>"$HOME/invalid" &&
@@ -49,7 +49,7 @@ test_expect_success 'UTF-8 invalid characters refused' '
4949
'
5050

5151
test_expect_success 'UTF-8 overlong sequences rejected' '
52-
test_when_finished "rm -f $HOME/stderr $HOME/invalid" &&
52+
test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
5353
rm -f "$HOME/stderr" "$HOME/invalid" &&
5454
echo "UTF-8 overlong" >F &&
5555
printf "\340\202\251ommit message\n\nThis is not a space:\300\240\n" \
@@ -59,7 +59,7 @@ test_expect_success 'UTF-8 overlong sequences rejected' '
5959
'
6060

6161
test_expect_success 'UTF-8 non-characters refused' '
62-
test_when_finished "rm -f $HOME/stderr $HOME/invalid" &&
62+
test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
6363
echo "UTF-8 non-character 1" >F &&
6464
printf "Commit message\n\nNon-character:\364\217\277\276\n" \
6565
>"$HOME/invalid" &&
@@ -68,7 +68,7 @@ test_expect_success 'UTF-8 non-characters refused' '
6868
'
6969

7070
test_expect_success 'UTF-8 non-characters refused' '
71-
test_when_finished "rm -f $HOME/stderr $HOME/invalid" &&
71+
test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
7272
echo "UTF-8 non-character 2." >F &&
7373
printf "Commit message\n\nNon-character:\357\267\220\n" \
7474
>"$HOME/invalid" &&

t/t7500-commit.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@ EOF
130130
test_expect_success 'commit message from template with whitespace issue' '
131131
echo "content galore" >>foo &&
132132
git add foo &&
133-
GIT_EDITOR="$TEST_DIRECTORY"/t7500/add-whitespaced-content git commit \
134-
--template "$TEMPLATE" &&
133+
GIT_EDITOR=\""$TEST_DIRECTORY"\"/t7500/add-whitespaced-content \
134+
git commit --template "$TEMPLATE" &&
135135
commit_msg_is "commit message"
136136
'
137137

t/t9020-remote-svn.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ init_git () {
2525
git init &&
2626
#git remote add svnsim testsvn::sim:///$TEST_DIRECTORY/t9020/example.svnrdump
2727
# let's reuse an existing dump file!?
28-
git remote add svnsim testsvn::sim://$TEST_DIRECTORY/t9154/svn.dump
29-
git remote add svnfile testsvn::file://$TEST_DIRECTORY/t9154/svn.dump
28+
git remote add svnsim "testsvn::sim://$TEST_DIRECTORY/t9154/svn.dump"
29+
git remote add svnfile "testsvn::file://$TEST_DIRECTORY/t9154/svn.dump"
3030
}
3131

3232
if test -e "$GIT_BUILD_DIR/git-remote-testsvn"

t/t9107-git-svn-migrate.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ test_expect_success 'git-svn-HEAD is a real HEAD' '
2828
git rev-parse --verify refs/heads/git-svn-HEAD^0
2929
'
3030

31-
svnrepo_escaped=$(echo $svnrepo | sed 's/ /%20/')
31+
svnrepo_escaped=$(echo $svnrepo | sed 's/ /%20/g')
3232

3333
test_expect_success 'initialize old-style (v0) git svn layout' '
3434
mkdir -p "$GIT_DIR"/git-svn/info "$GIT_DIR"/svn/info &&

0 commit comments

Comments
 (0)