Skip to content

Commit d830d39

Browse files
committed
builtin/send-pack.c: respect user.signingkey
When git-send-pack is exec'ed, as is done by git-remote-http, it does not read the config, and configured value of user.signingkey is ignored. Thus it was impossible to specify a signing key over HTTP, other than the default key in the keyring having a User ID matching the "Name <email>" format. This patch at least partially fixes the problem by reading in the GPG config from within send-pack. It does not address the related problem of plumbing a value for this configuration option using `git -c user.signingkey push ...`. Signed-off-by: Dave Borowitz <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent bb3e7b1 commit d830d39

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

builtin/send-pack.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include "transport.h"
1212
#include "version.h"
1313
#include "sha1-array.h"
14+
#include "gpg-interface.h"
1415

1516
static const char send_pack_usage[] =
1617
"git send-pack [--all | --mirror] [--dry-run] [--force] [--receive-pack=<git-receive-pack>] [--verbose] [--thin] [--atomic] [<host>:]<directory> [<ref>...]\n"
@@ -113,6 +114,8 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)
113114
int from_stdin = 0;
114115
struct push_cas_option cas = {0};
115116

117+
git_config(git_gpg_config, NULL);
118+
116119
argv++;
117120
for (i = 1; i < argc; i++, argv++) {
118121
const char *arg = *argv;

0 commit comments

Comments
 (0)