Skip to content

Commit d8dc823

Browse files
committed
Merge branch 'as/test-cleanup'
* as/test-cleanup: t7102 (reset): don't hardcode SHA-1 in expected outputs
2 parents ba96aa6 + 8b66f78 commit d8dc823

File tree

1 file changed

+21
-20
lines changed

1 file changed

+21
-20
lines changed

t/t7102-reset.sh

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ test_expect_success 'creating initial files and commits' '
2828
2929
echo "1st line 2nd file" >secondfile &&
3030
echo "2nd line 2nd file" >>secondfile &&
31-
git commit -a -m "modify 2nd file"
31+
git commit -a -m "modify 2nd file" &&
32+
head5=$(git rev-parse --verify HEAD)
3233
'
3334
# git log --pretty=oneline # to see those SHA1 involved
3435

@@ -56,7 +57,7 @@ test_expect_success 'giving a non existing revision should fail' '
5657
test_must_fail git reset --mixed aaaaaa &&
5758
test_must_fail git reset --soft aaaaaa &&
5859
test_must_fail git reset --hard aaaaaa &&
59-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc
60+
check_changes $head5
6061
'
6162

6263
test_expect_success 'reset --soft with unmerged index should fail' '
@@ -74,7 +75,7 @@ test_expect_success \
7475
test_must_fail git reset --hard -- first &&
7576
test_must_fail git reset --soft HEAD^ -- first &&
7677
test_must_fail git reset --hard HEAD^ -- first &&
77-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc
78+
check_changes $head5
7879
'
7980

8081
test_expect_success 'giving unrecognized options should fail' '
@@ -86,7 +87,7 @@ test_expect_success 'giving unrecognized options should fail' '
8687
test_must_fail git reset --soft -o &&
8788
test_must_fail git reset --hard --other &&
8889
test_must_fail git reset --hard -o &&
89-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc
90+
check_changes $head5
9091
'
9192

9293
test_expect_success \
@@ -110,7 +111,7 @@ test_expect_success \
110111
111112
git checkout master &&
112113
git branch -D branch1 branch2 &&
113-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc
114+
check_changes $head5
114115
'
115116

116117
test_expect_success \
@@ -133,27 +134,27 @@ test_expect_success \
133134
134135
git checkout master &&
135136
git branch -D branch3 branch4 &&
136-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc
137+
check_changes $head5
137138
'
138139

139140
test_expect_success \
140141
'resetting to HEAD with no changes should succeed and do nothing' '
141142
git reset --hard &&
142-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc &&
143+
check_changes $head5 &&
143144
git reset --hard HEAD &&
144-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc &&
145+
check_changes $head5 &&
145146
git reset --soft &&
146-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc &&
147+
check_changes $head5 &&
147148
git reset --soft HEAD &&
148-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc &&
149+
check_changes $head5 &&
149150
git reset --mixed &&
150-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc &&
151+
check_changes $head5 &&
151152
git reset --mixed HEAD &&
152-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc &&
153+
check_changes $head5 &&
153154
git reset &&
154-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc &&
155+
check_changes $head5 &&
155156
git reset HEAD &&
156-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc
157+
check_changes $head5
157158
'
158159

159160
>.diff_expect
@@ -176,7 +177,7 @@ test_expect_success '--soft reset only should show changes in diff --cached' '
176177
git reset --soft HEAD^ &&
177178
check_changes d1a4bc3abce4829628ae2dcb0d60ef3d1a78b1c4 &&
178179
test "$(git rev-parse ORIG_HEAD)" = \
179-
3ec39651e7f44ea531a5de18a9fa791c0fd370fc
180+
$head5
180181
'
181182

182183
>.diff_expect
@@ -193,7 +194,7 @@ test_expect_success \
193194
git commit -a -C ORIG_HEAD &&
194195
check_changes 3d3b7be011a58ca0c179ae45d94e6c83c0b0cd0d &&
195196
test "$(git rev-parse ORIG_HEAD)" = \
196-
3ec39651e7f44ea531a5de18a9fa791c0fd370fc
197+
$head5
197198
'
198199

199200
>.diff_expect
@@ -303,7 +304,7 @@ test_expect_success 'redoing the last two commits should succeed' '
303304
echo "1st line 2nd file" >secondfile &&
304305
echo "2nd line 2nd file" >>secondfile &&
305306
git commit -a -m "modify 2nd file" &&
306-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc
307+
check_changes $head5
307308
'
308309

309310
>.diff_expect
@@ -341,15 +342,15 @@ EOF
341342
test_expect_success \
342343
'--hard reset to ORIG_HEAD should clear a fast-forward merge' '
343344
git reset --hard HEAD^ &&
344-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc &&
345+
check_changes $head5 &&
345346
346347
git pull . branch1 &&
347348
git reset --hard ORIG_HEAD &&
348-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc &&
349+
check_changes $head5 &&
349350
350351
git checkout master &&
351352
git branch -D branch1 branch2 &&
352-
check_changes 3ec39651e7f44ea531a5de18a9fa791c0fd370fc
353+
check_changes $head5
353354
'
354355

355356
cat > expect << EOF

0 commit comments

Comments
 (0)