Skip to content

Commit d93f7c1

Browse files
ArjenLJunio C Hamano
authored andcommitted
t5300-pack-object.sh: portability issue using /usr/bin/stat
In the test 'compare delta flavors', /usr/bin/stat is used to get file size. This isn't portable. There already is a dependency on Perl, use its '-s' operator to get the file size. Signed-off-by: Arjen Laarhoven <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 4c84f0d commit d93f7c1

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

t/t5300-pack-object.sh

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,12 @@ test_expect_success \
123123
done'
124124
cd "$TRASH"
125125

126-
test_expect_success \
127-
'compare delta flavors' \
128-
'size_2=`stat -c "%s" test-2-${packname_2}.pack` &&
129-
size_3=`stat -c "%s" test-3-${packname_3}.pack` &&
130-
test $size_2 -gt $size_3'
126+
test_expect_success 'compare delta flavors' '
127+
perl -e '\''
128+
defined($_ = -s $_) or die for @ARGV;
129+
exit 1 if $ARGV[0] <= $ARGV[1];
130+
'\'' test-2-$packname_2.pack test-3-$packname_3.pack
131+
'
131132

132133
rm -fr .git2
133134
mkdir .git2

0 commit comments

Comments
 (0)