Skip to content

Commit d966e6a

Browse files
committed
Properly handle '0' filenames in import-tars
Randal L. Schwartz pointed out multiple times that we should be testing the length of the name string here, not if it is "true". The problem is the string '0' is actually false in Perl when we try to evaluate it in this context, as '0' is 0 numerically and the number 0 is treated as a false value. This would cause us to break out of the import loop early if anyone had a file or directory named "0". Signed-off-by: Shawn O. Pearce <[email protected]>
1 parent 53a5824 commit d966e6a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

contrib/fast-import/import-tars.perl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
$prefix) = unpack 'Z100 Z8 Z8 Z8 Z12 Z12
5252
Z8 Z1 Z100 Z6
5353
Z2 Z32 Z32 Z8 Z8 Z*', $_;
54-
last unless $name;
54+
last unless length($name);
5555
if ($name eq '././@LongLink') {
5656
# GNU tar extension
5757
if (read(I, $_, 512) != 512) {

0 commit comments

Comments
 (0)