Skip to content

Commit d96dab8

Browse files
bk2204gitster
authored andcommitted
builtin/ls-remote: initialize repository based on fetch
ls-remote may or may not operate within a repository, and as such will not have been initialized with the repository's hash algorithm. Even if it were, the remote side could be using a different algorithm and we would still want to display those refs properly. Find the hash algorithm used by the remote side by querying the transport object and set our hash algorithm accordingly. Without this change, if the remote side is using SHA-256, we truncate the refs to 40 hex characters, since that's the length of the default hash algorithm (SHA-1). Note that technically this is not a correct setting of the repository hash algorithm since, if we are in a repository, it might be one of a different hash algorithm from the remote side. However, our current code paths don't handle multiple algorithms and won't for some time, so this is the best we can do. We rely on the fact that ls-remote never modifies the current repository, which is a reasonable assumption to make. Signed-off-by: brian m. carlson <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent f0af95f commit d96dab8

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

builtin/ls-remote.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,10 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
118118
transport->server_options = &server_options;
119119

120120
ref = transport_get_remote_refs(transport, &ref_prefixes);
121+
if (ref) {
122+
int hash_algo = hash_algo_by_ptr(transport_get_hash_algo(transport));
123+
repo_set_hash_algo(the_repository, hash_algo);
124+
}
121125
if (transport_disconnect(transport)) {
122126
UNLEAK(sorting);
123127
return 1;

0 commit comments

Comments
 (0)