Skip to content

Commit da41c94

Browse files
jrtc27gitster
authored andcommitted
pack-bitmap: don't perform unaligned memory access
The preceding bitmap entries have a 1-byte XOR-offset and 1-byte flags, so their size is not a multiple of 4. Thus the name-hash cache is only guaranteed to be 2-byte aligned and so we must use get_be32 rather than indexing the array directly. Signed-off-by: James Clarke <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 840ed14 commit da41c94

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pack-bitmap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ static void show_objects_for_type(
627627
sha1 = nth_packed_object_sha1(bitmap_git.pack, entry->nr);
628628

629629
if (bitmap_git.hashes)
630-
hash = ntohl(bitmap_git.hashes[entry->nr]);
630+
hash = get_be32(bitmap_git.hashes + entry->nr);
631631

632632
show_reach(sha1, object_type, 0, hash, bitmap_git.pack, entry->offset);
633633
}

0 commit comments

Comments
 (0)