[PATCH] Missing test_done

Pavel Roskin · Junio C Hamano · commit da7bc9b081ad · 2005-08-11T18:26:15.000-07:00
All test scripts should end with test_done, which reports the test
results.  In the future, it could be used for other purposes, e.g. to
distinguish graceful end from "exit" in a test.  This patch fixes
scripts that don't call test_done.

Signed-off-by: Pavel Roskin &lt;proski@gnu.org&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/t/t2003-checkout-cache-mkdir.sh b/t/t2003-checkout-cache-mkdir.sh
@@ -93,3 +93,4 @@ test_expect_success \
      test -d tmp-path1 &&
      test -f tmp-path1/file1'
 
+test_done
diff --git a/t/t3001-ls-files-others-exclude.sh b/t/t3001-ls-files-others-exclude.sh
@@ -66,3 +66,5 @@ test_expect_success \
        --exclude-from=.git/ignore \
        >output &&
      diff -u expect output'
+
+test_done
diff --git a/t/t4101-apply-nonl.sh b/t/t4101-apply-nonl.sh
@@ -30,3 +30,5 @@ do
 	"git-apply <diff.$i-$j && diff frotz.$j frotz"
   done
 done
+
+test_done
diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh
@@ -52,3 +52,5 @@ test_expect_success \
 	git-send-pack --force ./victim/.git/ master &&
 	cmp victim/.git/refs/heads/master .git/refs/heads/master
 '
+
+test_done

Original file line number	Diff line number	Diff line change
`@@ -93,3 +93,4 @@ test_expect_success \`
`93`	`93`	`test -d tmp-path1 &&`
`94`	`94`	`test -f tmp-path1/file1'`
`95`	`95`
	`96`	`+test_done`
Original file line number	Diff line number	Diff line change
`@@ -52,3 +52,5 @@ test_expect_success \`
`52`	`52`	`git-send-pack --force ./victim/.git/ master &&`
`53`	`53`	`cmp victim/.git/refs/heads/master .git/refs/heads/master`
`54`	`54`	`'`
	`55`	`+`
	`56`	`+test_done`