Skip to content

Commit db4a3f2

Browse files
dschogitster
authored andcommitted
tests: mark a couple more test cases as requiring rebase -p
The `--preserve-merges` option has been deprecated, and as a consequence we started to mark test cases that require that option to be supported, in preparation for removing that support eventually. Since we marked those test cases, a couple more crept into the test suite, and with this patch, we mark them, too. Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 427c3bd commit db4a3f2

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

t/t3422-rebase-incompatible-options.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,13 @@ test_rebase_am_only --ignore-whitespace
6565
test_rebase_am_only --committer-date-is-author-date
6666
test_rebase_am_only -C4
6767

68-
test_expect_success '--preserve-merges incompatible with --signoff' '
68+
test_expect_success REBASE_P '--preserve-merges incompatible with --signoff' '
6969
git checkout B^0 &&
7070
test_must_fail git rebase --preserve-merges --signoff A
7171
'
7272

73-
test_expect_success '--preserve-merges incompatible with --rebase-merges' '
73+
test_expect_success REBASE_P \
74+
'--preserve-merges incompatible with --rebase-merges' '
7475
git checkout B^0 &&
7576
test_must_fail git rebase --preserve-merges --rebase-merges A
7677
'

t/t3427-rebase-subtree.sh

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ test_expect_success 'setup' '
3838
'
3939

4040
# FAILURE: Does not preserve master4.
41-
test_expect_failure 'Rebase -Xsubtree --preserve-merges --onto commit 4' '
41+
test_expect_failure REBASE_P \
42+
'Rebase -Xsubtree --preserve-merges --onto commit 4' '
4243
reset_rebase &&
4344
git checkout -b rebase-preserve-merges-4 master &&
4445
git filter-branch --prune-empty -f --subdirectory-filter files_subtree &&
@@ -48,7 +49,8 @@ test_expect_failure 'Rebase -Xsubtree --preserve-merges --onto commit 4' '
4849
'
4950

5051
# FAILURE: Does not preserve master5.
51-
test_expect_failure 'Rebase -Xsubtree --preserve-merges --onto commit 5' '
52+
test_expect_failure REBASE_P \
53+
'Rebase -Xsubtree --preserve-merges --onto commit 5' '
5254
reset_rebase &&
5355
git checkout -b rebase-preserve-merges-5 master &&
5456
git filter-branch --prune-empty -f --subdirectory-filter files_subtree &&
@@ -58,7 +60,8 @@ test_expect_failure 'Rebase -Xsubtree --preserve-merges --onto commit 5' '
5860
'
5961

6062
# FAILURE: Does not preserve master4.
61-
test_expect_failure 'Rebase -Xsubtree --keep-empty --preserve-merges --onto commit 4' '
63+
test_expect_failure REBASE_P \
64+
'Rebase -Xsubtree --keep-empty --preserve-merges --onto commit 4' '
6265
reset_rebase &&
6366
git checkout -b rebase-keep-empty-4 master &&
6467
git filter-branch --prune-empty -f --subdirectory-filter files_subtree &&
@@ -68,7 +71,8 @@ test_expect_failure 'Rebase -Xsubtree --keep-empty --preserve-merges --onto comm
6871
'
6972

7073
# FAILURE: Does not preserve master5.
71-
test_expect_failure 'Rebase -Xsubtree --keep-empty --preserve-merges --onto commit 5' '
74+
test_expect_failure REBASE_P \
75+
'Rebase -Xsubtree --keep-empty --preserve-merges --onto commit 5' '
7276
reset_rebase &&
7377
git checkout -b rebase-keep-empty-5 master &&
7478
git filter-branch --prune-empty -f --subdirectory-filter files_subtree &&
@@ -78,7 +82,8 @@ test_expect_failure 'Rebase -Xsubtree --keep-empty --preserve-merges --onto comm
7882
'
7983

8084
# FAILURE: Does not preserve Empty.
81-
test_expect_failure 'Rebase -Xsubtree --keep-empty --preserve-merges --onto empty commit' '
85+
test_expect_failure REBASE_P \
86+
'Rebase -Xsubtree --keep-empty --preserve-merges --onto empty commit' '
8287
reset_rebase &&
8388
git checkout -b rebase-keep-empty-empty master &&
8489
git filter-branch --prune-empty -f --subdirectory-filter files_subtree &&

0 commit comments

Comments
 (0)