push: do not pretend to return int from die_push_simple()

dscho · dscho · commit dc64e056d1b0 · 2019-05-10T14:07:43.000+02:00
This function is marked as `NORETURN`, and it indeed does not want to
return anything. So let's not declare it with the return type `int`.
This fixes the following warning when building with MSVC:

	C4646: function declared with 'noreturn' has non-void return type

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
diff --git a/builtin/push.c b/builtin/push.c
@@ -144,8 +144,8 @@ static int push_url_of_remote(struct remote *remote, const char ***url_p)
 	return remote->url_nr;
 }
 
-static NORETURN int die_push_simple(struct branch *branch,
-				    struct remote *remote)
+static NORETURN void die_push_simple(struct branch *branch,
+				     struct remote *remote)
 {
 	/*
 	 * There's no point in using shorten_unambiguous_ref here,

Original file line number	Diff line number	Diff line change
`@@ -144,8 +144,8 @@ static int push_url_of_remote(struct remote remote, const char **url_p)`
`144`	`144`	`return remote->url_nr;`
`145`	`145`	`}`
`146`	`146`
`147`		`-static NORETURN int die_push_simple(struct branch *branch,`
`148`		`- struct remote *remote)`
	`147`	`+static NORETURN void die_push_simple(struct branch *branch,`
	`148`	`+ struct remote *remote)`
`149`	`149`	`{`
`150`	`150`	`/*`
`151`	`151`	`* There's no point in using shorten_unambiguous_ref here,`