Skip to content

Commit e0f7ae5

Browse files
periperidipgitster
authored andcommitted
submodule: eliminate unused parameters from print_submodule_summary()
Eliminate the parameters 'missing_{src,dst}' from the 'print_submodule_summary()' function call since they are not used anywhere in the function. Reported-by: Jeff King <[email protected]> Mentored-by: Christian Couder <[email protected]> Mentored-by: Kaartic Sivaraam <[email protected]> Signed-off-by: Shourya Shukla <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e83e333 commit e0f7ae5

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

builtin/submodule--helper.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,6 @@ static char* verify_submodule_committish(const char *sm_path,
982982
static void print_submodule_summary(struct summary_cb *info, char* errmsg,
983983
int total_commits, const char *displaypath,
984984
const char *src_abbrev, const char *dst_abbrev,
985-
int missing_src, int missing_dst,
986985
struct module_cb *p)
987986
{
988987
if (p->status == 'T') {
@@ -1154,8 +1153,7 @@ static void generate_submodule_summary(struct summary_cb *info,
11541153

11551154
print_submodule_summary(info, errmsg, total_commits,
11561155
displaypath, src_abbrev,
1157-
dst_abbrev, missing_src,
1158-
missing_dst, p);
1156+
dst_abbrev, p);
11591157

11601158
free(displaypath);
11611159
free(src_abbrev);

0 commit comments

Comments
 (0)