Skip to content

Commit e498257

Browse files
Michael J Grubergitster
authored andcommitted
Documentation/SubmittingPatches: clarify GMail section and SMTP
We keep getting mangled submissions from GMail's web interface. Try to be more proactive in SubmittingPatches by - pointing to MUA specific instructions early on, - structuring the GMail section more clearly, - putting send-email/SMTP before imap-send/IMAP. Signed-off-by: Michael J Gruber <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent bd7440f commit e498257

File tree

1 file changed

+21
-19
lines changed

1 file changed

+21
-19
lines changed

Documentation/SubmittingPatches

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Checklist (and a short version for the impatient):
4141
maintainer ([email protected]) if (and only if) the patch
4242
is ready for inclusion. If you use git-send-email(1),
4343
please test it first by sending email to yourself.
44+
- see below for instructions specific to your mailer
4445

4546
Long version:
4647

@@ -519,9 +520,27 @@ Gmail
519520

520521
GMail does not appear to have any way to turn off line wrapping in the web
521522
interface, so this will mangle any emails that you send. You can however
522-
use any IMAP email client to connect to the google imap server, and forward
523+
use "git send e-mail" and send your patches through the GMail SMTP server, or
524+
use any IMAP email client to connect to the google IMAP server and forward
523525
the emails through that.
524526

527+
To use "git send-email" and send your patches through the GMail SMTP server,
528+
edit ~/.gitconfig to specify your account settings:
529+
530+
[sendemail]
531+
smtpencryption = tls
532+
smtpserver = smtp.gmail.com
533+
smtpuser = [email protected]
534+
smtppass = p4ssw0rd
535+
smtpserverport = 587
536+
537+
Once your commits are ready to be sent to the mailing list, run the
538+
following commands:
539+
540+
$ git format-patch --cover-letter -M origin/master -o outgoing/
541+
$ edit outgoing/0000-*
542+
$ git send-email outgoing/*
543+
525544
To submit using the IMAP interface, first, edit your ~/.gitconfig to specify your
526545
account settings:
527546

@@ -537,28 +556,11 @@ You might need to instead use: folder = "[Google Mail]/Drafts" if you get an err
537556
that the "Folder doesn't exist".
538557

539558
Once your commits are ready to be sent to the mailing list, run the
540-
following command to send the patch emails to your Gmail Drafts
541-
folder.
559+
following commands:
542560

543561
$ git format-patch --cover-letter -M --stdout origin/master | git imap-send
544562

545563
Just make sure to disable line wrapping in the email client (GMail web
546564
interface will line wrap no matter what, so you need to use a real
547565
IMAP client).
548566

549-
Alternatively, you can use "git send-email" and send your patches
550-
through the GMail SMTP server. edit ~/.gitconfig to specify your
551-
account settings:
552-
553-
[sendemail]
554-
smtpencryption = tls
555-
smtpserver = smtp.gmail.com
556-
smtpuser = [email protected]
557-
smtppass = p4ssw0rd
558-
smtpserverport = 587
559-
560-
Once your commits are ready to be sent to the mailing list, run the
561-
following commands:
562-
563-
$ git format-patch --cover-letter -M origin/master -o outgoing/
564-
$ git send-email outgoing/*

0 commit comments

Comments
 (0)