Skip to content

Commit e5e056b

Browse files
peffgitster
authored andcommitted
run-command: mark unused async callback parameters
The start_async(), etc, functions need a "proc" callback that conforms to a particular interface. Not every callback needs every parameter (e.g., the caller might not even ask to open an input descriptor, in which case there is no point in the callback looking at it). Let's mark these for -Wunused-parameter. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 555ff1c commit e5e056b

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

builtin/receive-pack.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ static void rp_error(const char *err, ...)
465465
va_end(params);
466466
}
467467

468-
static int copy_to_sideband(int in, int out, void *arg)
468+
static int copy_to_sideband(int in, int UNUSED(out), void *UNUSED(arg))
469469
{
470470
char data[128];
471471
int keepalive_active = 0;

convert.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,7 @@ struct filter_params {
619619
const char *path;
620620
};
621621

622-
static int filter_buffer_or_fd(int in, int out, void *data)
622+
static int filter_buffer_or_fd(int UNUSED(in), int out, void *data)
623623
{
624624
/*
625625
* Spawn cmd and feed the buffer contents through its stdin.

fetch-pack.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ static int everything_local(struct fetch_pack_args *args,
823823
return retval;
824824
}
825825

826-
static int sideband_demux(int in, int out, void *data)
826+
static int sideband_demux(int UNUSED(in), int out, void *data)
827827
{
828828
int *xd = data;
829829
int ret;

send-pack.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ static int receive_status(struct packet_reader *reader, struct ref *refs)
266266
return ret;
267267
}
268268

269-
static int sideband_demux(int in, int out, void *data)
269+
static int sideband_demux(int UNUSED(in), int out, void *data)
270270
{
271271
int *fd = data, ret;
272272
if (async_with_fork())

0 commit comments

Comments
 (0)