Skip to content

Commit e646a82

Browse files
committed
Merge branch 'bn/http-cookiefile-config' into maint
"http.cookieFile" configuration variable clearly wants a pathname, but we forgot to treat it as such by e.g. applying tilde expansion. * bn/http-cookiefile-config: http: expand http.cookieFile as a path Documentation: config: improve word ordering for http.cookieFile
2 parents 68a6e97 + e5a39ad commit e646a82

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Documentation/config.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1669,11 +1669,12 @@ http.emptyAuth::
16691669
authentication.
16701670

16711671
http.cookieFile::
1672-
File containing previously stored cookie lines which should be used
1672+
The pathname of a file containing previously stored cookie lines,
1673+
which should be used
16731674
in the Git http session, if they match the server. The file format
16741675
of the file to read cookies from should be plain HTTP headers or
16751676
the Netscape/Mozilla cookie file format (see `curl(1)`).
1676-
NOTE that the file specified with http.cookieFile is only used as
1677+
NOTE that the file specified with http.cookieFile is used only as
16771678
input unless http.saveCookies is set.
16781679

16791680
http.saveCookies::

http.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ static int http_options(const char *var, const char *value, void *cb)
293293
return git_config_string(&http_proxy_authmethod, var, value);
294294

295295
if (!strcmp("http.cookiefile", var))
296-
return git_config_string(&curl_cookie_file, var, value);
296+
return git_config_pathname(&curl_cookie_file, var, value);
297297
if (!strcmp("http.savecookies", var)) {
298298
curl_save_cookies = git_config_bool(var, value);
299299
return 0;

0 commit comments

Comments
 (0)