Skip to content

Commit e6604c3

Browse files
jrngitster
authored andcommitted
log doc: the argument to --encoding is not optional
$ git log --encoding fatal: Option '--encoding' requires a value $ git rev-list --encoding fatal: Option '--encoding' requires a value The argument to --encoding has always been mandatory. Unfortunately manpages like git-rev-list(1), git-log(1), and git-show(1) have described the option's syntax as "--encoding[=<encoding>]" since it was first documented. Clarify by removing the extra brackets. Signed-off-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 117eea7 commit e6604c3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Documentation/git-rev-list.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ SYNOPSIS
4040
[ \--right-only ]
4141
[ \--cherry-mark ]
4242
[ \--cherry-pick ]
43-
[ \--encoding[=<encoding>] ]
43+
[ \--encoding=<encoding> ]
4444
[ \--(author|committer|grep)=<pattern> ]
4545
[ \--regexp-ignore-case | -i ]
4646
[ \--extended-regexp | -E ]

Documentation/pretty-options.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ people using 80-column terminals.
2828
This is a shorthand for "--pretty=oneline --abbrev-commit"
2929
used together.
3030

31-
--encoding[=<encoding>]::
31+
--encoding=<encoding>::
3232
The commit objects record the encoding used for the log message
3333
in their encoding header; this option can be used to tell the
3434
command to re-code the commit log message in the encoding

0 commit comments

Comments
 (0)