Skip to content

Commit e6daf0a

Browse files
committed
Merge branch 'ab/diff-write-incomplete-line'
The output from "git diff -B" for a file that ends with an incomplete line did not put "\ No newline..." on a line of its own. * ab/diff-write-incomplete-line: Fix '\ No newline...' annotation in rewrite diffs
2 parents e3fe714 + 35e2d03 commit e6daf0a

File tree

2 files changed

+31
-0
lines changed

2 files changed

+31
-0
lines changed

diff.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -574,6 +574,7 @@ static void emit_rewrite_lines(struct emit_callback *ecb,
574574
if (!endp) {
575575
const char *plain = diff_get_color(ecb->color_diff,
576576
DIFF_PLAIN);
577+
putc('\n', ecb->opt->file);
577578
emit_line_0(ecb->opt, plain, reset, '\\',
578579
nneof, strlen(nneof));
579580
}

t/t4022-diff-rewrite.sh

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,5 +66,35 @@ test_expect_success 'suppress deletion diff with -B -D' '
6666
grep -v "Linus Torvalds" actual
6767
'
6868

69+
test_expect_success 'prepare a file that ends with an incomplete line' '
70+
test_seq 1 99 >seq &&
71+
printf 100 >>seq &&
72+
git add seq &&
73+
git commit seq -m seq
74+
'
75+
76+
test_expect_success 'rewrite the middle 90% of sequence file and terminate with newline' '
77+
test_seq 1 5 >seq &&
78+
test_seq 9331 9420 >>seq &&
79+
test_seq 96 100 >>seq
80+
'
81+
82+
test_expect_success 'confirm that sequence file is considered a rewrite' '
83+
git diff -B seq >res &&
84+
grep "dissimilarity index" res
85+
'
86+
87+
test_expect_success 'no newline at eof is on its own line without -B' '
88+
git diff seq >res &&
89+
grep "^\\\\ " res &&
90+
! grep "^..*\\\\ " res
91+
'
92+
93+
test_expect_success 'no newline at eof is on its own line with -B' '
94+
git diff -B seq >res &&
95+
grep "^\\\\ " res &&
96+
! grep "^..*\\\\ " res
97+
'
98+
6999
test_done
70100

0 commit comments

Comments
 (0)