Skip to content

Commit e7c3a59

Browse files
committed
builtin/diff.c: remove duplicated call to diff_result_code()
The return value from builtin_diff_files() is fed to diff_result_code() by the caller, and all other callees like builtin_diff_index() do not have their own call to diff_result_code(). Remove the duplicated one from builtin_diff_files() and let the caller handle it. Signed-off-by: Junio C Hamano <[email protected]>
1 parent c2e86ad commit e7c3a59

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

builtin/diff.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,6 @@ static void refresh_index_quietly(void)
207207

208208
static int builtin_diff_files(struct rev_info *revs, int argc, const char **argv)
209209
{
210-
int result;
211210
unsigned int options = 0;
212211

213212
while (1 < argc && argv[1][0] == '-') {
@@ -241,8 +240,7 @@ static int builtin_diff_files(struct rev_info *revs, int argc, const char **argv
241240
perror("read_cache_preload");
242241
return -1;
243242
}
244-
result = run_diff_files(revs, options);
245-
return diff_result_code(&revs->diffopt, result);
243+
return run_diff_files(revs, options);
246244
}
247245

248246
int cmd_diff(int argc, const char **argv, const char *prefix)

0 commit comments

Comments
 (0)