close_sha1_file(): make it easier to diagnose errors

torvalds · gitster · commit e8bd78c3fcba · 2009-03-24T14:39:20.000-07:00
A bug report with "unable to write sha1 file" made us realize that we do
not have enough information to guess why close() is failing.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/sha1_file.c b/sha1_file.c
@@ -2241,7 +2241,7 @@ static void close_sha1_file(int fd)
 		fsync_or_die(fd, "sha1 file");
 	fchmod(fd, 0444);
 	if (close(fd) != 0)
-		die("unable to write sha1 file");
+		die("error when closing sha1 file (%s)", strerror(errno));
 }
 
 /* Size of directory component, including the ending '/' */

Original file line number	Diff line number	Diff line change
`@@ -2241,7 +2241,7 @@ static void close_sha1_file(int fd)`
`2241`	`2241`	`fsync_or_die(fd, "sha1 file");`
`2242`	`2242`	`fchmod(fd, 0444);`
`2243`	`2243`	`if (close(fd) != 0)`
`2244`		`- die("unable to write sha1 file");`
	`2244`	`+ die("error when closing sha1 file (%s)", strerror(errno));`
`2245`	`2245`	`}`
`2246`	`2246`
`2247`	`2247`	`/* Size of directory component, including the ending '/' */`