Skip to content

Commit e90f6b2

Browse files
pks-tgitster
authored andcommitted
gitlab-ci: ignore failures to disable realtime monitoring
We have recently introduced a change to disable realtime monitoring for Windows job in GitLab CI. This change led (and still leads) to a quite significant speedup. But there's a catch: seemingly, some of the runners we use already have realtime monitoring disabled. On such a machine, trying to disable the feature again leads to an error that causes the whole job to fail. Safeguard against such failures by explicitly ignoring them. Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 5c2ebf6 commit e90f6b2

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.gitlab-ci.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,10 @@ test:osx:
113113
when: on_failure
114114

115115
.windows_before_script: &windows_before_script
116-
- Set-MpPreference -DisableRealtimeMonitoring $true
116+
# Disabling realtime monitoring fails on some of the runners, but it
117+
# significantly speeds up test execution in the case where it works. We thus
118+
# try our luck, but ignore any failures.
119+
- Set-MpPreference -DisableRealtimeMonitoring $true; $true
117120

118121
build:mingw64:
119122
stage: build

0 commit comments

Comments
 (0)