Skip to content

Commit e9d309e

Browse files
Denton-Lgitster
authored andcommitted
t7610: unsuppress output
The output for commands used to be suppressed by redirecting both stdout and stderr to /dev/null. However, this should not happen since the output is useful for debugging and, without the "-v" flag, test scripts don't output anyway. Unsuppress the output by removing the redirections to /dev/null. Signed-off-by: Denton Liu <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent c217b93 commit e9d309e

File tree

1 file changed

+61
-61
lines changed

1 file changed

+61
-61
lines changed

t/t7610-mergetool.sh

Lines changed: 61 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,14 @@ test_expect_success 'custom mergetool' '
130130
test_when_finished "git reset --hard" &&
131131
git checkout -b test$test_count branch1 &&
132132
git submodule update -N &&
133-
test_must_fail git merge master >/dev/null 2>&1 &&
134-
( yes "" | git mergetool both >/dev/null 2>&1 ) &&
133+
test_must_fail git merge master &&
134+
( yes "" | git mergetool both ) &&
135135
( yes "" | git mergetool file1 file1 ) &&
136-
( yes "" | git mergetool file2 "spaced name" >/dev/null 2>&1 ) &&
137-
( yes "" | git mergetool subdir/file3 >/dev/null 2>&1 ) &&
138-
( yes "d" | git mergetool file11 >/dev/null 2>&1 ) &&
139-
( yes "d" | git mergetool file12 >/dev/null 2>&1 ) &&
140-
( yes "l" | git mergetool submod >/dev/null 2>&1 ) &&
136+
( yes "" | git mergetool file2 "spaced name" ) &&
137+
( yes "" | git mergetool subdir/file3 ) &&
138+
( yes "d" | git mergetool file11 ) &&
139+
( yes "d" | git mergetool file12 ) &&
140+
( yes "l" | git mergetool submod ) &&
141141
test "$(cat file1)" = "master updated" &&
142142
test "$(cat file2)" = "master new" &&
143143
test "$(cat subdir/file3)" = "master new sub" &&
@@ -153,15 +153,15 @@ test_expect_success 'mergetool crlf' '
153153
# test_when_finished is LIFO.)
154154
test_config core.autocrlf true &&
155155
git checkout -b test$test_count branch1 &&
156-
test_must_fail git merge master >/dev/null 2>&1 &&
157-
( yes "" | git mergetool file1 >/dev/null 2>&1 ) &&
158-
( yes "" | git mergetool file2 >/dev/null 2>&1 ) &&
159-
( yes "" | git mergetool "spaced name" >/dev/null 2>&1 ) &&
160-
( yes "" | git mergetool both >/dev/null 2>&1 ) &&
161-
( yes "" | git mergetool subdir/file3 >/dev/null 2>&1 ) &&
162-
( yes "d" | git mergetool file11 >/dev/null 2>&1 ) &&
163-
( yes "d" | git mergetool file12 >/dev/null 2>&1 ) &&
164-
( yes "r" | git mergetool submod >/dev/null 2>&1 ) &&
156+
test_must_fail git merge master &&
157+
( yes "" | git mergetool file1 ) &&
158+
( yes "" | git mergetool file2 ) &&
159+
( yes "" | git mergetool "spaced name" ) &&
160+
( yes "" | git mergetool both ) &&
161+
( yes "" | git mergetool subdir/file3 ) &&
162+
( yes "d" | git mergetool file11 ) &&
163+
( yes "d" | git mergetool file12 ) &&
164+
( yes "r" | git mergetool submod ) &&
165165
test "$(printf x | cat file1 -)" = "$(printf "master updated\r\nx")" &&
166166
test "$(printf x | cat file2 -)" = "$(printf "master new\r\nx")" &&
167167
test "$(printf x | cat subdir/file3 -)" = "$(printf "master new sub\r\nx")" &&
@@ -176,8 +176,8 @@ test_expect_success 'mergetool in subdir' '
176176
git submodule update -N &&
177177
(
178178
cd subdir &&
179-
test_must_fail git merge master >/dev/null 2>&1 &&
180-
( yes "" | git mergetool file3 >/dev/null 2>&1 ) &&
179+
test_must_fail git merge master &&
180+
( yes "" | git mergetool file3 ) &&
181181
test "$(cat file3)" = "master new sub"
182182
)
183183
'
@@ -188,14 +188,14 @@ test_expect_success 'mergetool on file in parent dir' '
188188
git submodule update -N &&
189189
(
190190
cd subdir &&
191-
test_must_fail git merge master >/dev/null 2>&1 &&
192-
( yes "" | git mergetool file3 >/dev/null 2>&1 ) &&
193-
( yes "" | git mergetool ../file1 >/dev/null 2>&1 ) &&
194-
( yes "" | git mergetool ../file2 ../spaced\ name >/dev/null 2>&1 ) &&
195-
( yes "" | git mergetool ../both >/dev/null 2>&1 ) &&
196-
( yes "d" | git mergetool ../file11 >/dev/null 2>&1 ) &&
197-
( yes "d" | git mergetool ../file12 >/dev/null 2>&1 ) &&
198-
( yes "l" | git mergetool ../submod >/dev/null 2>&1 ) &&
191+
test_must_fail git merge master &&
192+
( yes "" | git mergetool file3 ) &&
193+
( yes "" | git mergetool ../file1 ) &&
194+
( yes "" | git mergetool ../file2 ../spaced\ name ) &&
195+
( yes "" | git mergetool ../both ) &&
196+
( yes "d" | git mergetool ../file11 ) &&
197+
( yes "d" | git mergetool ../file12 ) &&
198+
( yes "l" | git mergetool ../submod ) &&
199199
test "$(cat ../file1)" = "master updated" &&
200200
test "$(cat ../file2)" = "master new" &&
201201
test "$(cat ../submod/bar)" = "branch1 submodule" &&
@@ -209,9 +209,9 @@ test_expect_success 'mergetool skips autoresolved' '
209209
git submodule update -N &&
210210
test_must_fail git merge master &&
211211
test -n "$(git ls-files -u)" &&
212-
( yes "d" | git mergetool file11 >/dev/null 2>&1 ) &&
213-
( yes "d" | git mergetool file12 >/dev/null 2>&1 ) &&
214-
( yes "l" | git mergetool submod >/dev/null 2>&1 ) &&
212+
( yes "d" | git mergetool file11 ) &&
213+
( yes "d" | git mergetool file12 ) &&
214+
( yes "l" | git mergetool submod ) &&
215215
output="$(git mergetool --no-prompt)" &&
216216
test "$output" = "No files need merging"
217217
'
@@ -259,9 +259,9 @@ test_expect_success 'mergetool skips resolved paths when rerere is active' '
259259
rm -rf .git/rr-cache &&
260260
git checkout -b test$test_count branch1 &&
261261
git submodule update -N &&
262-
test_must_fail git merge master >/dev/null 2>&1 &&
263-
( yes "l" | git mergetool --no-prompt submod >/dev/null 2>&1 ) &&
264-
( yes "d" "d" | git mergetool --no-prompt >/dev/null 2>&1 ) &&
262+
test_must_fail git merge master &&
263+
( yes "l" | git mergetool --no-prompt submod ) &&
264+
( yes "d" "d" | git mergetool --no-prompt ) &&
265265
git submodule update -N &&
266266
output="$(yes "n" | git mergetool --no-prompt)" &&
267267
test "$output" = "No files need merging"
@@ -369,9 +369,9 @@ test_expect_success 'deleted vs modified submodule' '
369369
git checkout -b test$test_count.a test$test_count &&
370370
test_must_fail git merge master &&
371371
test -n "$(git ls-files -u)" &&
372-
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 >/dev/null 2>&1 ) &&
373-
( yes "" | git mergetool both >/dev/null 2>&1 ) &&
374-
( yes "d" | git mergetool file11 file12 >/dev/null 2>&1 ) &&
372+
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 ) &&
373+
( yes "" | git mergetool both ) &&
374+
( yes "d" | git mergetool file11 file12 ) &&
375375
( yes "r" | git mergetool submod ) &&
376376
rmdir submod && mv submod-movedaside submod &&
377377
test "$(cat submod/bar)" = "branch1 submodule" &&
@@ -386,9 +386,9 @@ test_expect_success 'deleted vs modified submodule' '
386386
git submodule update -N &&
387387
test_must_fail git merge master &&
388388
test -n "$(git ls-files -u)" &&
389-
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 >/dev/null 2>&1 ) &&
390-
( yes "" | git mergetool both >/dev/null 2>&1 ) &&
391-
( yes "d" | git mergetool file11 file12 >/dev/null 2>&1 ) &&
389+
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 ) &&
390+
( yes "" | git mergetool both ) &&
391+
( yes "d" | git mergetool file11 file12 ) &&
392392
( yes "l" | git mergetool submod ) &&
393393
test ! -e submod &&
394394
output="$(git mergetool --no-prompt)" &&
@@ -400,9 +400,9 @@ test_expect_success 'deleted vs modified submodule' '
400400
git submodule update -N &&
401401
test_must_fail git merge test$test_count &&
402402
test -n "$(git ls-files -u)" &&
403-
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 >/dev/null 2>&1 ) &&
404-
( yes "" | git mergetool both >/dev/null 2>&1 ) &&
405-
( yes "d" | git mergetool file11 file12 >/dev/null 2>&1 ) &&
403+
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 ) &&
404+
( yes "" | git mergetool both ) &&
405+
( yes "d" | git mergetool file11 file12 ) &&
406406
( yes "r" | git mergetool submod ) &&
407407
test ! -e submod &&
408408
test -d submod.orig &&
@@ -416,9 +416,9 @@ test_expect_success 'deleted vs modified submodule' '
416416
git submodule update -N &&
417417
test_must_fail git merge test$test_count &&
418418
test -n "$(git ls-files -u)" &&
419-
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 >/dev/null 2>&1 ) &&
420-
( yes "" | git mergetool both >/dev/null 2>&1 ) &&
421-
( yes "d" | git mergetool file11 file12 >/dev/null 2>&1 ) &&
419+
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 ) &&
420+
( yes "" | git mergetool both ) &&
421+
( yes "d" | git mergetool file11 file12 ) &&
422422
( yes "l" | git mergetool submod ) &&
423423
test "$(cat submod/bar)" = "master submodule" &&
424424
git submodule update -N &&
@@ -440,9 +440,9 @@ test_expect_success 'file vs modified submodule' '
440440
git checkout -b test$test_count.a branch1 &&
441441
test_must_fail git merge master &&
442442
test -n "$(git ls-files -u)" &&
443-
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 >/dev/null 2>&1 ) &&
444-
( yes "" | git mergetool both >/dev/null 2>&1 ) &&
445-
( yes "d" | git mergetool file11 file12 >/dev/null 2>&1 ) &&
443+
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 ) &&
444+
( yes "" | git mergetool both ) &&
445+
( yes "d" | git mergetool file11 file12 ) &&
446446
( yes "r" | git mergetool submod ) &&
447447
rmdir submod && mv submod-movedaside submod &&
448448
test "$(cat submod/bar)" = "branch1 submodule" &&
@@ -456,9 +456,9 @@ test_expect_success 'file vs modified submodule' '
456456
git checkout -b test$test_count.b test$test_count &&
457457
test_must_fail git merge master &&
458458
test -n "$(git ls-files -u)" &&
459-
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 >/dev/null 2>&1 ) &&
460-
( yes "" | git mergetool both >/dev/null 2>&1 ) &&
461-
( yes "d" | git mergetool file11 file12 >/dev/null 2>&1 ) &&
459+
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 ) &&
460+
( yes "" | git mergetool both ) &&
461+
( yes "d" | git mergetool file11 file12 ) &&
462462
( yes "l" | git mergetool submod ) &&
463463
git submodule update -N &&
464464
test "$(cat submod)" = "not a submodule" &&
@@ -472,9 +472,9 @@ test_expect_success 'file vs modified submodule' '
472472
git submodule update -N &&
473473
test_must_fail git merge test$test_count &&
474474
test -n "$(git ls-files -u)" &&
475-
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 >/dev/null 2>&1 ) &&
476-
( yes "" | git mergetool both >/dev/null 2>&1 ) &&
477-
( yes "d" | git mergetool file11 file12 >/dev/null 2>&1 ) &&
475+
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 ) &&
476+
( yes "" | git mergetool both ) &&
477+
( yes "d" | git mergetool file11 file12 ) &&
478478
( yes "r" | git mergetool submod ) &&
479479
test -d submod.orig &&
480480
git submodule update -N &&
@@ -488,9 +488,9 @@ test_expect_success 'file vs modified submodule' '
488488
git submodule update -N &&
489489
test_must_fail git merge test$test_count &&
490490
test -n "$(git ls-files -u)" &&
491-
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 >/dev/null 2>&1 ) &&
492-
( yes "" | git mergetool both>/dev/null 2>&1 ) &&
493-
( yes "d" | git mergetool file11 file12 >/dev/null 2>&1 ) &&
491+
( yes "" | git mergetool file1 file2 spaced\ name subdir/file3 ) &&
492+
( yes "" | git mergetool both ) &&
493+
( yes "d" | git mergetool file11 file12 ) &&
494494
( yes "l" | git mergetool submod ) &&
495495
test "$(cat submod/bar)" = "master submodule" &&
496496
git submodule update -N &&
@@ -543,7 +543,7 @@ test_expect_success 'submodule in subdirectory' '
543543
git add subdir/subdir_module &&
544544
git commit -m "change submodule in subdirectory on test$test_count.b" &&
545545
546-
test_must_fail git merge test$test_count.a >/dev/null 2>&1 &&
546+
test_must_fail git merge test$test_count.a &&
547547
(
548548
cd subdir &&
549549
( yes "l" | git mergetool subdir_module )
@@ -554,7 +554,7 @@ test_expect_success 'submodule in subdirectory' '
554554
git reset --hard &&
555555
git submodule update -N &&
556556
557-
test_must_fail git merge test$test_count.a >/dev/null 2>&1 &&
557+
test_must_fail git merge test$test_count.a &&
558558
( yes "r" | git mergetool subdir/subdir_module ) &&
559559
test "$(cat subdir/subdir_module/file15)" = "test$test_count.b" &&
560560
git submodule update -N &&
@@ -641,7 +641,7 @@ test_expect_success 'filenames seen by tools start with ./' '
641641
test_config mergetool.myecho.trustExitCode true &&
642642
test_must_fail git merge master &&
643643
git mergetool --no-prompt --tool myecho -- both >actual &&
644-
grep ^\./both_LOCAL_ actual >/dev/null
644+
grep ^\./both_LOCAL_ actual
645645
'
646646

647647
test_lazy_prereq MKTEMP '
@@ -658,8 +658,8 @@ test_expect_success MKTEMP 'temporary filenames are used with mergetool.writeToT
658658
test_config mergetool.myecho.trustExitCode true &&
659659
test_must_fail git merge master &&
660660
git mergetool --no-prompt --tool myecho -- both >actual &&
661-
! grep ^\./both_LOCAL_ actual >/dev/null &&
662-
grep /both_LOCAL_ actual >/dev/null
661+
! grep ^\./both_LOCAL_ actual &&
662+
grep /both_LOCAL_ actual
663663
'
664664

665665
test_expect_success 'diff.orderFile configuration is honored' '

0 commit comments

Comments
 (0)