Skip to content

Commit e9d866e

Browse files
peffgitster
authored andcommitted
t5500: give fully-qualified refs to fetch-pack
The fetch-pack documentation is very clear that refs given on the command line are to be full refs: <refs>...:: The remote heads to update from. This is relative to $GIT_DIR (e.g. "HEAD", "refs/heads/master"). When unspecified, update from all heads the remote side has. and this has been the case since fetch-pack was originally documented in 8b3d9dc ([PATCH] Documentation: clone/fetch/upload., 2005-07-14). Let's follow our own documentation to set a good example, and to avoid breaking when this restriction is enforced in the next patch. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent afe7c5f commit e9d866e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

t/t5500-fetch-pack.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ test_expect_success 'setup' '
9797
git symbolic-ref HEAD refs/heads/B
9898
'
9999

100-
pull_to_client 1st "B A" $((11*3))
100+
pull_to_client 1st "refs/heads/B refs/heads/A" $((11*3))
101101

102102
test_expect_success 'post 1st pull setup' '
103103
add A11 $A10 &&
@@ -110,9 +110,9 @@ test_expect_success 'post 1st pull setup' '
110110
done
111111
'
112112

113-
pull_to_client 2nd "B" $((64*3))
113+
pull_to_client 2nd "refs/heads/B" $((64*3))
114114

115-
pull_to_client 3rd "A" $((1*3))
115+
pull_to_client 3rd "refs/heads/A" $((1*3))
116116

117117
test_expect_success 'clone shallow' '
118118
git clone --depth 2 "file://$(pwd)/." shallow

0 commit comments

Comments
 (0)