remote-hg: trivial cleanups

felipec · gitster · commit eb7976e7dddf · 2013-05-15T12:30:36.000-07:00
Drop unused "global", and remove redundant comparison of two files.

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
@@ -538,7 +538,7 @@ def list_head(repo, cur):
     g_head = (head, node)
 
 def do_list(parser):
-    global branches, bmarks, mode, track_branches
+    global branches, bmarks, track_branches
 
     repo = parser.repo
     for bmark, node in bookmarks.listbookmarks(repo).iteritems():
diff --git a/contrib/remote-helpers/test-hg-hg-git.sh b/contrib/remote-helpers/test-hg-hg-git.sh
@@ -455,8 +455,6 @@ test_expect_success 'hg author' '
 		git_log gitrepo-$x > git-log-$x
 	done &&
 
-	test_cmp git-log-hg git-log-git &&
-
 	test_cmp hg-log-hg hg-log-git &&
 	test_cmp git-log-hg git-log-git
 '

Original file line number	Diff line number	Diff line change
`@@ -455,8 +455,6 @@ test_expect_success 'hg author' '`
`455`	`455`	`git_log gitrepo-$x > git-log-$x`
`456`	`456`	`done &&`
`457`	`457`
`458`		`- test_cmp git-log-hg git-log-git &&`
`459`		`-`
`460`	`458`	`test_cmp hg-log-hg hg-log-git &&`
`461`	`459`	`test_cmp git-log-hg git-log-git`
`462`	`460`	`'`