Skip to content

Commit eb7cc5b

Browse files
szedergitster
authored andcommitted
t5318: use 'test_cmp_bin' to compare commit-graph files
The commit-graph files are binary files, so they should not be compared with 'test_cmp', because that might cause issues like crashing[1] or infinite loop[2] on Windows, where 'test_cmp' is a shell function to deal with random LF-CRLF conversions[3]. Use 'test_cmp_bin' instead. 1 - b93e6e3 (t5000, t5003: do not use test_cmp to compare binary files, 2014-06-04) 2 - f9f3851 (t9300: use test_cmp_bin instead of test_cmp to compare binary files, 2014-09-12) 3 - 4d715ac (Windows: a test_cmp that is agnostic to random LF <> CRLF conversions, 2013-10-26) Reviewed-by: Derrick Stolee <[email protected]> Signed-off-by: SZEDER Gábor <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b18ef13 commit eb7cc5b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/t5318-commit-graph.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,9 @@ test_expect_success 'check that gc computes commit-graph' '
254254
git config gc.writeCommitGraph true &&
255255
git gc &&
256256
cp $objdir/info/commit-graph commit-graph-after-gc &&
257-
! test_cmp commit-graph-before-gc commit-graph-after-gc &&
257+
! test_cmp_bin commit-graph-before-gc commit-graph-after-gc &&
258258
git commit-graph write --reachable &&
259-
test_cmp commit-graph-after-gc $objdir/info/commit-graph
259+
test_cmp_bin commit-graph-after-gc $objdir/info/commit-graph
260260
'
261261

262262
# the verify tests below expect the commit-graph to contain

0 commit comments

Comments
 (0)