Skip to content

Commit ec2f6c0

Browse files
newrengitster
authored andcommitted
t6429: fix use of non-existent function
This test had a line reading ! test_file_is_empty actual which was meant to be ! test_must_be_empty actual The test worked despite the error, because even though test_file_is_empty is a non-existent function, the '!' negated the return value and made it pass. It'd be better to avoid the negation, so something like test_file_not_empty actual would be better, but perhaps it makes even more sense to specify the number of lines of expected output to make the test a bit tighter. Reported-by: SZEDER Gábor <[email protected]> Signed-off-by: Elijah Newren <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent dc8c8de commit ec2f6c0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t6429-merge-sequence-rename-caching.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -760,7 +760,7 @@ test_expect_success 'avoid assuming we detected renames' '
760760
test_must_fail git -c merge.renameLimit=1 rebase upstream &&
761761
762762
git ls-files -u >actual &&
763-
! test_file_is_empty actual
763+
test_line_count = 2 actual
764764
)
765765
'
766766

0 commit comments

Comments
 (0)