builtin/describe: fix trivial memory leak when describing blob

pks-t · gitster · commit ed041007f09f · 2024-08-01T08:47:35.000-07:00
We never free the `struct strvec args` variable in `describe_blob()`,
which thus causes a memory leak. Fix this.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/describe.c b/builtin/describe.c
@@ -529,6 +529,7 @@ static void describe_blob(struct object_id oid, struct strbuf *dst)
 	traverse_commit_list(&revs, process_commit, process_object, &pcd);
 	reset_revision_walk();
 	release_revisions(&revs);
+	strvec_clear(&args);
 }
 
 static void describe(const char *arg, int last_one)
diff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh
@@ -8,6 +8,7 @@ test_description='test git-specific bash prompt functions'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-bash.sh
 
 . "$GIT_BUILD_DIR/contrib/completion/git-prompt.sh"

Original file line number	Diff line number	Diff line change
`@@ -529,6 +529,7 @@ static void describe_blob(struct object_id oid, struct strbuf *dst)`
`529`	`529`	`traverse_commit_list(&revs, process_commit, process_object, &pcd);`
`530`	`530`	`reset_revision_walk();`
`531`	`531`	`release_revisions(&revs);`
	`532`	`+ strvec_clear(&args);`
`532`	`533`	`}`
`533`	`534`
`534`	`535`	`static void describe(const char *arg, int last_one)`