Skip to content

Commit ed73388

Browse files
committed
git-gui: Make TclTk 8.6 the minimum, allow 8.7
git-gui requires that Tcl and Tk are 8.5, though the check using 'package require' allows 8.6. As git-gui runs under wish, both Tcl and Tk are always available and of the same version, so only one need be checked. The 8.5 requirement is very outdated as the earliest Tcl currently shipping on any supported OS is 8.6. 8.7 is in alpha test and is generally compatible with 8.6, so should also be allowed. Tcl 9.0 has planned compatibility breaking changes so cannot be allowed. Let's update the requirements to be 8.6 or 8.7, and check only on Tcl as Tk will be the same version. Signed-off-by: Mark Levedahl <[email protected]>
1 parent 3f07230 commit ed73388

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

git-gui.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ along with this program; if not, see <https://www.gnu.org/licenses/>.}]
3030
##
3131
## Tcl/Tk sanity check
3232

33-
if {[catch {package require Tcl 8.5} err]
34-
|| [catch {package require Tk 8.5} err]
35-
} {
33+
if {[catch {package require Tcl 8.6-8.8} err]} {
3634
catch {wm withdraw .}
3735
tk_messageBox \
3836
-icon error \

0 commit comments

Comments
 (0)