Skip to content

Commit edb6a17

Browse files
avargitster
authored andcommitted
Makefile: NO_OPENSSL=1 should no longer imply BLK_SHA1=1
Use the collision detecting SHA-1 implementation by default even when NO_OPENSSL is set. Setting NO_OPENSSL=UnfortunatelyYes has implied BLK_SHA1=1 ever since the former was introduced in dd53c7a (Support for NO_OPENSSL, 2005-07-29). That implication should have been removed when the default SHA-1 implementation changed from OpenSSL to DC_SHA1 in e6b07da (Makefile: make DC_SHA1 the default, 2017-03-17). Finish what that commit started by removing the BLK_SHA1 fallback setting so the default DC_SHA1 implementation will be used. Helped-by: Jonathan Nieder <[email protected]> Reviewed-by: Jonathan Nieder <[email protected]> Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Reviewed-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 29533fb commit edb6a17

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

Makefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ all::
2323
# it at all).
2424
#
2525
# Define NO_OPENSSL environment variable if you do not have OpenSSL.
26-
# This also implies BLK_SHA1.
2726
#
2827
# Define USE_LIBPCRE if you have and want to use libpcre. Various
2928
# commands such as log and grep offer runtime options to use
@@ -1260,7 +1259,6 @@ ifndef NO_OPENSSL
12601259
endif
12611260
else
12621261
BASIC_CFLAGS += -DNO_OPENSSL
1263-
BLK_SHA1 = 1
12641262
OPENSSL_LIBSSL =
12651263
endif
12661264
ifdef NO_OPENSSL

configure.ac

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ AC_MSG_NOTICE([CHECKS for site configuration])
241241
# a bundled SHA1 routine optimized for PowerPC.
242242
#
243243
# Define NO_OPENSSL environment variable if you do not have OpenSSL.
244-
# This also implies BLK_SHA1.
245244
#
246245
# Define OPENSSLDIR=/foo/bar if your openssl header and library files are in
247246
# /foo/bar/include and /foo/bar/lib directories.

0 commit comments

Comments
 (0)