Skip to content

Commit f200197

Browse files
jrngitster
authored andcommitted
Makefile: BLK_SHA1 does not require fast htonl() and unaligned loads
block-sha1/ is fast on most known platforms. Clarify the Makefile to be less misleading about that. Early versions of block-sha1/ explicitly relied on fast htonl() and fast 32-bit loads with arbitrary alignment. Now it uses those on some arches but the default behavior is byte-at-a-time access for the sake of arches like ARM, Alpha, and their kin and it is still pretty fast on these arches (fast enough to supersede the mozilla SHA1 implementation and the hand-written ARM assembler implementation that were bundled before). Signed-off-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 23119ff commit f200197

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

Makefile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,8 @@ all::
8484
# specify your own (or DarwinPort's) include directories and
8585
# library directories by defining CFLAGS and LDFLAGS appropriately.
8686
#
87-
# Define BLK_SHA1 environment variable if you want the C version
88-
# of the SHA1 that assumes you can do unaligned 32-bit loads and
89-
# have a fast htonl() function.
87+
# Define BLK_SHA1 environment variable to make use of the bundled
88+
# optimized C SHA1 routine.
9089
#
9190
# Define PPC_SHA1 environment variable when running make to make use of
9291
# a bundled SHA1 routine optimized for PowerPC.

0 commit comments

Comments
 (0)