Skip to content

Commit f279894

Browse files
neerajsi-msft2gitster
authored andcommitted
read-cache: make the index write buffer size 128K
Writing an index 8K at a time invokes the OS filesystem and caching code very frequently, introducing noticeable overhead while writing large indexes. When experimenting with different write buffer sizes on Windows writing the Windows OS repo index (260MB), most of the benefit came by bumping the index write buffer size to 64K. I picked 128K to ensure that we're past the knee of the curve. With this change, the time under do_write_index for an index with 3M files goes from ~1.02s to ~0.72s. Signed-off-by: Neeraj Singh <[email protected]> Acked-by: Jeff Hostetler <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 966e671 commit f279894

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

read-cache.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2447,7 +2447,7 @@ int repo_index_has_changes(struct repository *repo,
24472447
}
24482448
}
24492449

2450-
#define WRITE_BUFFER_SIZE 8192
2450+
#define WRITE_BUFFER_SIZE (128 * 1024)
24512451
static unsigned char write_buffer[WRITE_BUFFER_SIZE];
24522452
static unsigned long write_buffer_len;
24532453

0 commit comments

Comments
 (0)